Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh: Add output flag #258

Merged
merged 10 commits into from
Mar 29, 2023
Merged

ssh: Add output flag #258

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a6aa2c3
use String() helps on test failures
petersutter Mar 20, 2023
2ff410c
use sigs.k8s.io yaml encoder
petersutter Mar 20, 2023
c77df6c
fix tests
petersutter Mar 20, 2023
f39be42
introduce types for public and private key file
petersutter Mar 20, 2023
85c9caf
reduce unnecessary complexity
petersutter Mar 21, 2023
21e528a
extract to String()
petersutter Mar 21, 2023
7a470a1
add output flag
petersutter Mar 21, 2023
ce53335
make gen-markdown
petersutter Mar 21, 2023
cadff5a
PR feedback - use PrivateKeyFile type
petersutter Mar 28, 2023
cfb2bcc
PR feedback - consistently use sigs.k8s.io/yaml
petersutter Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
use String() helps on test failures
  • Loading branch information
@petersutter
petersutter committed Mar 29, 2023
commit a6aa2c39c40f031869edf5bd5a3173946a89d51c
24 changes: 12 additions & 12 deletions pkg/cmd/ssh/ssh_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,9 +305,9 @@ var _ = Describe("SSH Command", func() {
Expect(cmd.RunE(cmd, nil)).To(Succeed())

// assert the output
Expect(logs).To(ContainSubstring(bastionName))
Expect(logs).To(ContainSubstring(bastionHostname))
Expect(out).To(ContainSubstring(bastionIP))
Expect(logs.String()).To(ContainSubstring(bastionName))
Expect(logs.String()).To(ContainSubstring(bastionHostname))
Expect(out.String()).To(ContainSubstring(bastionIP))

// assert that the bastion has been cleaned up
key := types.NamespacedName{Name: bastionName, Namespace: *testProject.Spec.Namespace}
Expand Down Expand Up @@ -357,9 +357,9 @@ var _ = Describe("SSH Command", func() {

// assert output
Expect(executedCommands).To(Equal(1))
Expect(logs).To(ContainSubstring(bastionName))
Expect(logs).To(ContainSubstring(bastionHostname))
Expect(out).To(ContainSubstring(bastionIP))
Expect(logs.String()).To(ContainSubstring(bastionName))
Expect(logs.String()).To(ContainSubstring(bastionHostname))
Expect(out.String()).To(ContainSubstring(bastionIP))

// assert that the bastion has been cleaned up
key := types.NamespacedName{Name: bastionName, Namespace: *testProject.Spec.Namespace}
Expand Down Expand Up @@ -411,10 +411,10 @@ var _ = Describe("SSH Command", func() {

// assert output
Expect(executedCommands).To(Equal(1))
Expect(logs).To(ContainSubstring(bastionName))
Expect(logs).To(ContainSubstring(bastionHostname))
Expect(out).To(ContainSubstring(bastionIP))
Expect(logs).To(ContainSubstring("node did not yet join the cluster"))
Expect(logs.String()).To(ContainSubstring(bastionName))
Expect(logs.String()).To(ContainSubstring(bastionHostname))
Expect(out.String()).To(ContainSubstring(bastionIP))
Expect(logs.String()).To(ContainSubstring("node did not yet join the cluster"))

// assert that the bastion has been cleaned up
key := types.NamespacedName{Name: bastionName, Namespace: *testProject.Spec.Namespace}
Expand Down Expand Up @@ -523,7 +523,7 @@ var _ = Describe("SSH Command", func() {

Expect(cmd.RunE(cmd, nil)).To(Succeed())

Expect(logs).To(ContainSubstring("Bastion is ready, skipping availability check"))
Expect(logs.String()).To(ContainSubstring("Bastion is ready, skipping availability check"))
})

It("should not keep alive the bastion", func() {
Expand All @@ -550,7 +550,7 @@ var _ = Describe("SSH Command", func() {

Expect(cmd.RunE(cmd, nil)).To(Succeed())

Expect(logs).To(ContainSubstring("Bastion host became available."))
Expect(logs.String()).To(ContainSubstring("Bastion host became available."))
})
})

Expand Down