Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssh: Add output flag #258

Merged
merged 10 commits into from
Mar 29, 2023
Merged

ssh: Add output flag #258

merged 10 commits into from
Mar 29, 2023

Conversation

petersutter
Copy link
Member

@petersutter petersutter commented Mar 21, 2023 •
edited
Loading

What this PR does / why we need it:
This PR adds an output flag for the ssh command

Usage example:

gardenctl ssh --no-keepalive --keep-bastion -oyaml

Output:

bastion:
  hostname: bastion.example.com
  ip: 1.2.3.4
  name: cli-budw1wnb
  namespace: garden-myproject
  preferredAddress: 1.2.3.4
  privateKeyFile: /foo/bar/gen_id_rsa_baz
  publicKeyFile: /foo/bar/gen_id_rsa_baz.pub
nodePrivateKeyFiles:
  - /foo/bar/gctlv23456
  - /foo/bar/gctlv24567
nodes:
  - hostname: node.example.com
    ip: 4.5.6.7
    name: node.name.internal
    status: Ready

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

`ssh`: You can now control the output format using `--output` flag

@petersutter petersutter requested a review from a team as a code owner March 21, 2023 10:51
@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Mar 21, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 21, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 21, 2023
holgerkoser
holgerkoser reviewed Mar 28, 2023
View reviewed changes
pkg/cmd/ssh/types.go Outdated Show resolved Hide resolved
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 28, 2023
holgerkoser
holgerkoser approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Mar 29, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 29, 2023
@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Mar 29, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 29, 2023
@petersutter petersutter merged commit 67e7dba into master Mar 29, 2023
@petersutter petersutter deleted the ssh-output-flag branch March 29, 2023 08:12
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 29, 2023
@petersutter petersutter added the area/ipcei IPCEI (Important Project of Common European Interest) label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerkoser holgerkoser holgerkoser approved these changes

Assignees
No one assigned
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@petersutter @holgerkoser @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot