Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: target cmd - only register target flags with higher specificty #206

Merged
merged 3 commits into from
Jan 20, 2023
Merged

enh: target cmd - only register target flags with higher specificty #206

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af74c33
enh: target cmd - only register target flags with higher specificty
sven-petersen Jan 3, 2023
461fd9e
expose TargetFlags on factory
sven-petersen Jan 19, 2023
6edafd4
PR feedback
sven-petersen Jan 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
PR feedback
  • Loading branch information
@sven-petersen
sven-petersen committed Jan 20, 2023
commit 6edafd49d5452d4aec2b51055248ed956bf37e83
2 changes: 1 addition & 1 deletion internal/util/factory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ type FactoryImpl struct {

var _ Factory = &FactoryImpl{}

func NewFactory() *FactoryImpl {
func NewFactoryImpl() *FactoryImpl {
return &FactoryImpl{
targetFlags: target.NewTargetFlags("", "", "", "", false),
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ func Execute() {

// NewDefaultGardenctlCommand creates the `gardenctl` command with defaults.
func NewDefaultGardenctlCommand() *cobra.Command {
factory := util.NewFactory()
factory := util.NewFactoryImpl()
ioStreams := util.NewIOStreams()

return NewGardenctlCommand(factory, ioStreams)
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/cmd_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ var _ = Describe("Gardenctl command", func() {
var factory *util.FactoryImpl

BeforeEach(func() {
factory = util.NewFactory()
factory = util.NewFactoryImpl()
})

Context("when running the completion command", func() {
Expand Down
2 changes: 1 addition & 1 deletion pkg/flags/target_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ var _ = Describe("Target flags", func() {
var factory *util.FactoryImpl

BeforeEach(func() {
factory = util.NewFactory()
factory = util.NewFactoryImpl()
})

Context("when wrapping completion functions", func() {
Expand Down