Remove inner try catch in SPDLOG_LOGGER_CATCH

The fmt::format call should not throw formatting the exception message and the source code location.
gabime · Aug 17, 2021 · 0d10e21 · 0d10e21
1 parent ed27592
commit 0d10e21
Showing 1 changed file with 1 addition and 8 deletions.
diff --git a/include/spdlog/logger.h b/include/spdlog/logger.h
@@ -33,14 +33,7 @@
         {                                                                                                                                  \
             if(location.filename)                                                                                                          \
             {                                                                                                                              \
-                try                                                                                                                        \
-                {                                                                                                                          \
-                    err_handler_(fmt::format("{} [{}({})]", ex.what(), location.filename, location.line));                                \
-                }                                                                                                                          \
-                catch (const std::exception &ex)                                                                                           \
-                {                                                                                                                          \
-                    err_handler_(ex.what());                                                                                               \
-                }                                                                                                                          \
+                err_handler_(fmt::format("{} [{}({})]", ex.what(), location.filename, location.line));                                     \
             }                                                                                                                              \
             else                                                                                                                           \
             {                                                                                                                              \