FIX Redundant throws clause

g711ab · Jul 7, 2015 · f0390ff · f0390ff
1 parent 0159164
commit f0390ff
Show file tree

Hide file tree

Showing 97 changed files with 307 additions and 307 deletions.
diff --git a/it/it-tests/src/test/java/qualitygate/QualityGateNotificationTest.java b/it/it-tests/src/test/java/qualitygate/QualityGateNotificationTest.java
@@ -43,7 +43,7 @@ public class QualityGateNotificationTest {
     .build();
 
   @Before
-  public void cleanUp() throws Exception {
+  public void cleanUp() {
     orchestrator.resetData();
   }
 

diff --git a/it/it-tests/src/test/java/qualitygate/QualityGateTest.java b/it/it-tests/src/test/java/qualitygate/QualityGateTest.java
@@ -38,7 +38,7 @@ public class QualityGateTest {
     .build();
 
   @Before
-  public void cleanUp() throws Exception {
+  public void cleanUp() {
     orchestrator.resetData();
     provisionnedProjectId = Long.parseLong(orchestrator.getServer().adminWsClient().projectClient().create(NewProject.create().key(PROJECT_KEY).name("Sample")).id());
   }

diff --git a/...nar-server-benchmarks/src/test/java/org/sonar/server/benchmark/SourceDbBenchmarkTest.java b/...nar-server-benchmarks/src/test/java/org/sonar/server/benchmark/SourceDbBenchmarkTest.java
@@ -60,7 +60,7 @@ public void benchmark() throws Exception {
     scrollRows();
   }
 
-  private void scrollRows() throws Exception {
+  private void scrollRows() {
     LOGGER.info("Scroll table FILE_SOURCES");
     AtomicLong counter = new AtomicLong();
     ProgressTask progress = new ProgressTask(LOGGER, "source file", counter);

diff --git a/...r-server/src/test/java/org/sonar/server/activity/index/ActivityResultSetIteratorTest.java b/...r-server/src/test/java/org/sonar/server/activity/index/ActivityResultSetIteratorTest.java
@@ -40,7 +40,7 @@ public class ActivityResultSetIteratorTest {
   public DbTester dbTester = DbTester.create(System2.INSTANCE);
 
   @Before
-  public void setUp() throws Exception {
+  public void setUp() {
     dbTester.truncateTables();
   }
 

diff --git a/server/sonar-server/src/test/java/org/sonar/server/batch/BatchWsModuleTest.java b/server/sonar-server/src/test/java/org/sonar/server/batch/BatchWsModuleTest.java
@@ -26,7 +26,7 @@
 
 public class BatchWsModuleTest {
   @Test
-  public void verify_count_of_added_components() throws Exception {
+  public void verify_count_of_added_components() {
     ComponentContainer container = new ComponentContainer();
     new BatchWsModule().configure(container);
     assertThat(container.size()).isEqualTo(10);

diff --git a/server/sonar-server/src/test/java/org/sonar/server/component/db/ComponentDaoTest.java b/server/sonar-server/src/test/java/org/sonar/server/component/db/ComponentDaoTest.java
@@ -498,7 +498,7 @@ public void count_provisioned_projects() {
   }
 
   @Test
-  public void select_ghost_projects() throws Exception {
+  public void select_ghost_projects() {
     db.prepareDbUnit(getClass(), "select_ghost_projects.xml");
 
     List<ComponentDto> result = sut.selectGhostProjects(session, null, new SearchOptions());

diff --git a/server/sonar-server/src/test/java/org/sonar/server/computation/ComputationServiceTest.java b/server/sonar-server/src/test/java/org/sonar/server/computation/ComputationServiceTest.java
@@ -58,12 +58,12 @@ public class ComputationServiceTest {
   ComputationService sut;
 
   @Before
-  public void setUp() throws IOException {
+  public void setUp() {
     sut = new ComputationService(new ReportQueue.Item(dto, new File("Do_not_care")), steps, activityManager, system);
   }
 
   @Test
-  public void process_new_project() throws Exception {
+  public void process_new_project() {
     logTester.setLevel(LoggerLevel.INFO);
 
     when(steps.instances()).thenReturn(Arrays.asList(projectStep1, projectStep2));
@@ -85,7 +85,7 @@ public void process_new_project() throws Exception {
   }
 
   @Test
-  public void debug_logs() throws Exception {
+  public void debug_logs() {
     when(steps.instances()).thenReturn(Collections.<ComputationStep>emptyList());
     logTester.setLevel(LoggerLevel.DEBUG);
 
@@ -95,7 +95,7 @@ public void debug_logs() throws Exception {
   }
 
   @Test
-  public void fail_if_step_throws_error() throws Exception {
+  public void fail_if_step_throws_error() {
     String errorMessage = "Failed to unzip";
     when(steps.instances()).thenReturn(ImmutableList.of(projectStep1));
     doThrow(new IllegalStateException(errorMessage)).when(projectStep1).execute();
@@ -111,7 +111,7 @@ public void fail_if_step_throws_error() throws Exception {
   }
 
   @Test
-  public void step_error() throws Exception {
+  public void step_error() {
     when(steps.instances()).thenReturn(Arrays.asList(projectStep1));
     doThrow(new IllegalStateException("pb")).when(projectStep1).execute();
 

diff --git a/server/sonar-server/src/test/java/org/sonar/server/computation/ReportQueueTest.java b/server/sonar-server/src/test/java/org/sonar/server/computation/ReportQueueTest.java
@@ -80,7 +80,7 @@ public void setUp() throws Exception {
   }
 
   @After
-  public void tearDown() throws Exception {
+  public void tearDown() {
     session.close();
   }
 

diff --git a/...sonar-server/src/test/java/org/sonar/server/computation/activity/ActivityManagerTest.java b/...sonar-server/src/test/java/org/sonar/server/computation/activity/ActivityManagerTest.java
@@ -49,15 +49,15 @@ public class ActivityManagerTest {
   ActivityManager underTest;
 
   @Before
-  public void setup() throws Exception {
+  public void setup() {
     dbTester.truncateTables();
     DbClient dbClient = new DbClient(dbTester.database(), dbTester.myBatis(), new ComponentDao());
 
     underTest = new ActivityManager(activityService, dbClient);
   }
 
   @Test
-  public void process_existing_project() throws Exception {
+  public void process_existing_project() {
     dbTester.prepareDbUnit(getClass(), "shared.xml");
 
     underTest.saveActivity(reportDto);
@@ -72,7 +72,7 @@ public void process_existing_project() throws Exception {
   }
 
   @Test
-  public void process_new_project() throws Exception {
+  public void process_new_project() {
     underTest.saveActivity(reportDto);
 
     // execute only the steps supporting the project qualifier

diff --git a/...ar-server/src/test/java/org/sonar/server/computation/batch/BatchReportReaderImplTest.java b/...ar-server/src/test/java/org/sonar/server/computation/batch/BatchReportReaderImplTest.java
@@ -62,7 +62,7 @@ public class BatchReportReaderImplTest {
   private FileStructure fileStructure;
 
   @Before
-  public void setUp() throws Exception {
+  public void setUp() {
     BatchReportDirectoryHolder holder = new ImmutableBatchReportDirectoryHolder(tempFolder.newDir());
     underTest = new BatchReportReaderImpl(holder);
     writer = new BatchReportWriter(holder.getDirectory());
@@ -257,7 +257,7 @@ public void readTests_returns_empty_CloseableIterator_when_file_does_not_exist()
   }
 
   @Test
-  public void verify_readTests() throws IOException {
+  public void verify_readTests() {
     writer.writeTests(COMPONENT_REF, of(TEST_1, TEST_2));
 
     CloseableIterator<BatchReport.Test> res = underTest.readTests(COMPONENT_REF);
@@ -271,7 +271,7 @@ public void readCoverageDetails_returns_empty_CloseableIterator_when_file_does_n
   }
 
   @Test
-  public void verify_readCoverageDetails() throws IOException {
+  public void verify_readCoverageDetails() {
     writer.writeCoverageDetails(COMPONENT_REF, of(COVERAGE_DETAIL_1, COVERAGE_DETAIL_2));
 
     CloseableIterator<BatchReport.CoverageDetail> res = underTest.readCoverageDetails(COMPONENT_REF);

diff --git a/.../sonar-server/src/test/java/org/sonar/server/computation/component/ComponentImplTest.java b/.../sonar-server/src/test/java/org/sonar/server/computation/component/ComponentImplTest.java
@@ -68,21 +68,21 @@ public void verify_setKey() {
   }
 
   @Test
-  public void get_name_from_batch_component() throws Exception {
+  public void get_name_from_batch_component() {
     String name = "project";
     ComponentImpl component = new ComponentImpl(BatchReport.Component.newBuilder().setName(name).build(), EMPTY_CHILD_LIST);
     assertThat(component.getName()).isEqualTo(name);
   }
 
   @Test
-  public void get_version_from_batch_component() throws Exception {
+  public void get_version_from_batch_component() {
     String version = "1.0";
     ComponentImpl component = new ComponentImpl(BatchReport.Component.newBuilder().setVersion(version).build(), EMPTY_CHILD_LIST);
     assertThat(component.getVersion()).isEqualTo(version);
   }
 
   @Test
-  public void getFileAttributes_throws_ISE_if_BatchComponent_does_not_have_type_FILE() throws Exception {
+  public void getFileAttributes_throws_ISE_if_BatchComponent_does_not_have_type_FILE() {
     for (ComponentType componentType : from(asList(ComponentType.values())).filter(not(equalTo(ComponentType.FILE)))) {
       ComponentImpl component = new ComponentImpl(BatchReport.Component.newBuilder().setType(componentType).build(), EMPTY_CHILD_LIST);
       try {
@@ -95,14 +95,14 @@ public void getFileAttributes_throws_ISE_if_BatchComponent_does_not_have_type_FI
   }
 
   @Test
-  public void isUnitTest_returns_true_if_IsTest_is_set_in_BatchComponent() throws Exception {
+  public void isUnitTest_returns_true_if_IsTest_is_set_in_BatchComponent() {
     ComponentImpl component = new ComponentImpl(BatchReport.Component.newBuilder().setType(ComponentType.FILE).setIsTest(true).build(), EMPTY_CHILD_LIST);
 
     assertThat(component.getFileAttributes().isUnitTest()).isTrue();
   }
 
   @Test
-  public void isUnitTest_returns_value_of_language_of_BatchComponent() throws Exception {
+  public void isUnitTest_returns_value_of_language_of_BatchComponent() {
     String languageKey = "some language key";
     ComponentImpl component = new ComponentImpl(BatchReport.Component.newBuilder().setType(ComponentType.FILE).setLanguage(languageKey).build(), EMPTY_CHILD_LIST);
 

diff --git a/server/sonar-server/src/test/java/org/sonar/server/computation/component/ComponentTest.java b/server/sonar-server/src/test/java/org/sonar/server/computation/component/ComponentTest.java
@@ -29,57 +29,57 @@
 
 public class ComponentTest {
   @Test
-  public void verify_type_is_deeper_than_when_comparing_to_itself() throws Exception {
+  public void verify_type_is_deeper_than_when_comparing_to_itself() {
     for (Component.Type type : Component.Type.values()) {
       assertThat(type.isDeeperThan(type)).isFalse();
     }
   }
 
   @Test
-  public void FILE_type_is_deeper_than_all_other_types() throws Exception {
+  public void FILE_type_is_deeper_than_all_other_types() {
     assertThat(Component.Type.FILE.isDeeperThan(DIRECTORY)).isTrue();
     assertThat(Component.Type.FILE.isDeeperThan(MODULE)).isTrue();
     assertThat(Component.Type.FILE.isDeeperThan(PROJECT)).isTrue();
   }
 
   @Test
-  public void DIRECTORY_type_is_deeper_than_MODULE_and_PROJECT() throws Exception {
+  public void DIRECTORY_type_is_deeper_than_MODULE_and_PROJECT() {
     assertThat(Component.Type.DIRECTORY.isDeeperThan(MODULE)).isTrue();
     assertThat(Component.Type.DIRECTORY.isDeeperThan(PROJECT)).isTrue();
   }
 
   @Test
-  public void MODULE_type_is_deeper_than_PROJECT() throws Exception {
+  public void MODULE_type_is_deeper_than_PROJECT() {
     assertThat(Component.Type.MODULE.isDeeperThan(PROJECT)).isTrue();
   }
 
   @Test
-  public void FILE_type_is_higher_than_no_other_types() throws Exception {
+  public void FILE_type_is_higher_than_no_other_types() {
     assertThat(Component.Type.FILE.isHigherThan(DIRECTORY)).isFalse();
     assertThat(Component.Type.FILE.isHigherThan(MODULE)).isFalse();
     assertThat(Component.Type.FILE.isHigherThan(PROJECT)).isFalse();
   }
 
   @Test
-  public void DIRECTORY_type_is_higher_than_FILE() throws Exception {
+  public void DIRECTORY_type_is_higher_than_FILE() {
     assertThat(Component.Type.DIRECTORY.isHigherThan(FILE)).isTrue();
   }
 
   @Test
-  public void MODULE_type_is_higher_than_FILE_AND_DIRECTORY() throws Exception {
+  public void MODULE_type_is_higher_than_FILE_AND_DIRECTORY() {
     assertThat(Component.Type.MODULE.isHigherThan(FILE)).isTrue();
     assertThat(Component.Type.MODULE.isHigherThan(DIRECTORY)).isTrue();
   }
 
   @Test
-  public void PROJECT_type_is_higher_than_all_other_types() throws Exception {
+  public void PROJECT_type_is_higher_than_all_other_types() {
     assertThat(Component.Type.PROJECT.isHigherThan(FILE)).isTrue();
     assertThat(Component.Type.PROJECT.isHigherThan(DIRECTORY)).isTrue();
     assertThat(Component.Type.PROJECT.isHigherThan(MODULE)).isTrue();
   }
 
   @Test
-  public void any_type_is_not_higher_than_itself() throws Exception {
+  public void any_type_is_not_higher_than_itself() {
     assertThat(Component.Type.FILE.isHigherThan(FILE)).isFalse();
     assertThat(Component.Type.DIRECTORY.isHigherThan(DIRECTORY)).isFalse();
     assertThat(Component.Type.MODULE.isHigherThan(MODULE)).isFalse();

diff --git a/...onar-server/src/test/java/org/sonar/server/computation/component/DbIdsRepositoryTest.java b/...onar-server/src/test/java/org/sonar/server/computation/component/DbIdsRepositoryTest.java
@@ -34,23 +34,23 @@ public class DbIdsRepositoryTest {
   Component component = DumbComponent.DUMB_PROJECT;
 
   @Test
-  public void add_and_get_component_id() throws Exception {
+  public void add_and_get_component_id() {
     DbIdsRepository cache = new DbIdsRepository();
     cache.setComponentId(component, 10L);
 
     assertThat(cache.getComponentId(component)).isEqualTo(10L);
   }
 
   @Test
-  public void fail_to_get_component_id_on_unknown_ref() throws Exception {
+  public void fail_to_get_component_id_on_unknown_ref() {
     thrown.expect(IllegalArgumentException.class);
     thrown.expectMessage("Component ref '" + component.getRef() + "' has no component id");
 
     new DbIdsRepository().getComponentId(DumbComponent.DUMB_PROJECT);
   }
 
   @Test
-  public void fail_if_component_id_already_set() throws Exception {
+  public void fail_if_component_id_already_set() {
     thrown.expect(IllegalArgumentException.class);
     thrown.expectMessage("Component ref '" + component.getRef() + "' has already a component id");
 
@@ -60,23 +60,23 @@ public void fail_if_component_id_already_set() throws Exception {
   }
 
   @Test
-  public void add_and_get_snapshot_id() throws Exception {
+  public void add_and_get_snapshot_id() {
     DbIdsRepository cache = new DbIdsRepository();
     cache.setSnapshotId(component, 100L);
 
     assertThat(cache.getSnapshotId(component)).isEqualTo(100L);
   }
 
   @Test
-  public void fail_to_get_snapshot_id_on_unknown_ref() throws Exception {
+  public void fail_to_get_snapshot_id_on_unknown_ref() {
     thrown.expect(IllegalArgumentException.class);
     thrown.expectMessage("Component ref '" + component.getRef() + "' has no snapshot id");
 
     new DbIdsRepository().getSnapshotId(DumbComponent.DUMB_PROJECT);
   }
 
   @Test
-  public void fail_if_snapshot_id_already_set() throws Exception {
+  public void fail_if_snapshot_id_already_set() {
     thrown.expect(IllegalArgumentException.class);
     thrown.expectMessage("Component ref '" + component.getRef() + "' has already a snapshot id");
 

diff --git a/...r/src/test/java/org/sonar/server/computation/component/ProjectSettingsRepositoryTest.java b/...r/src/test/java/org/sonar/server/computation/component/ProjectSettingsRepositoryTest.java
@@ -66,12 +66,12 @@ public void createDao() {
   }
 
   @After
-  public void tearDown() throws Exception {
+  public void tearDown() {
     session.close();
   }
 
   @Test
-  public void get_project_settings_from_global_settings() throws Exception {
+  public void get_project_settings_from_global_settings() {
     globalSettings.setProperty("key", "value");
 
     Settings settings = sut.getProjectSettings(PROJECT_KEY);
@@ -80,7 +80,7 @@ public void get_project_settings_from_global_settings() throws Exception {
   }
 
   @Test
-  public void get_project_settings_from_db() throws Exception {
+  public void get_project_settings_from_db() {
     ComponentDto project = ComponentTesting.newProjectDto().setKey(PROJECT_KEY);
     dbClient.componentDao().insert(session, project);
     dbClient.propertiesDao().setProperty(new PropertyDto().setResourceId(project.getId()).setKey("key").setValue("value"), session);
@@ -92,7 +92,7 @@ public void get_project_settings_from_db() throws Exception {
   }
 
   @Test
-  public void call_twice_get_project_settings() throws Exception {
+  public void call_twice_get_project_settings() {
     globalSettings.setProperty("key", "value");
 
     Settings settings = sut.getProjectSettings(PROJECT_KEY);

diff --git a/...r-server/src/test/java/org/sonar/server/computation/component/TreeRootHolderImplTest.java b/...r-server/src/test/java/org/sonar/server/computation/component/TreeRootHolderImplTest.java
@@ -52,7 +52,7 @@ public void verify_setRoot_getRoot() {
   }
 
   @Test
-  public void get_by_ref() throws Exception {
+  public void get_by_ref() {
     Component file = DumbComponent.builder(Component.Type.FILE, 4).build();
     Component directory = DumbComponent.builder(Component.Type.DIRECTORY, 3).addChildren(file).build();
     Component module = DumbComponent.builder(Component.Type.MODULE, 2).addChildren(directory).build();
@@ -66,13 +66,13 @@ public void get_by_ref() throws Exception {
   }
 
   @Test
-  public void fail_to_get_by_ref_if_root_not_set() throws Exception {
+  public void fail_to_get_by_ref_if_root_not_set() {
     thrown.expect(IllegalStateException.class);
     treeRootHolder.getComponentByRef(project.getRef());
   }
 
   @Test
-  public void fail_to_get_by_ref_if_ref_not_found() throws Exception {
+  public void fail_to_get_by_ref_if_ref_not_found() {
     thrown.expect(IllegalArgumentException.class);
     treeRootHolder.setRoot(project);
     treeRootHolder.getComponentByRef(123);

diff --git a/server/sonar-server/src/test/java/org/sonar/server/computation/debt/CharacteristicTest.java b/server/sonar-server/src/test/java/org/sonar/server/computation/debt/CharacteristicTest.java
@@ -62,7 +62,7 @@ public void test_equals_and_hashcode() throws Exception {
   }
 
   @Test
-  public void creating_a_new_characteristic_with_null_key_throws_a_NPE() throws Exception {
+  public void creating_a_new_characteristic_with_null_key_throws_a_NPE() {
     thrown.expect(NullPointerException.class);
     thrown.expectMessage("key cannot be null");
-Original file line number
+Diff line change
@@ Expand Up / @@ -80,7 +80,7 @@ public void setUp() throws Exception { @@
       }
       @After
-      public void tearDown() throws Exception {
+      public void tearDown() {
         session.close();
       }
@@ Expand Down @@