Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for responding to back button on Android #3948

Merged
merged 5 commits into from
Aug 1, 2023
Merged

Support for responding to back button on Android #3948

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
10bd7ce
Add initial support for responding to back button on Android
andydotxyz Jun 5, 2023
a4dafb3
Missing stubs from windows/linux
andydotxyz Jun 5, 2023
3ba8f1c
Merge branch 'develop' into feature/backbutton
andydotxyz Jul 28, 2023
8b545a8
Ensure to catch refreshed context on resume
andydotxyz Jul 29, 2023
38ad3a2
And if nobody handles the event go back as expected
andydotxyz Jul 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Missing stubs from windows/linux
  • Loading branch information
@andydotxyz
andydotxyz committed Jun 5, 2023
commit a4dafb35f23e0870a649698c6fe6ee38c37ef61f
4 changes: 4 additions & 0 deletions internal/driver/mobile/app/shiny.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ func main(f func(a App)) {
fmt.Errorf("Running mobile simulation mode does not currently work on Windows.")
}

func GoBack() {
// When simulating mobile there are no other activities open (and we can't just force background)
}

// driverShowVirtualKeyboard does nothing on desktop
func driverShowVirtualKeyboard(KeyboardType) {
}
Expand Down
4 changes: 4 additions & 0 deletions internal/driver/mobile/app/x11.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,10 @@ func main(f func(App)) {
}
}

func GoBack() {
// When simulating mobile there are no other activities open (and we can't just force background)
}

//export onResize
func onResize(w, h int) {
// TODO(nigeltao): don't assume 72 DPI. DisplayWidth and DisplayWidthMM
Expand Down