feat: Add partitionWith, partitionWithA, partitionEithers #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a generic
partitionWith
,witherable
seems to be the logical place for such a thing, as it can be implemented in terms of the existingFilterable
class.I added it to the
Filterable
class because more efficient versions may be available.Existing names I've found for this operation: Vector's
partitionWith
, base'spartitionEithers
, containers'mapEither
.I chose
partitionWith
, andpartitionEithers
, but I don't have a strong opinion on the name (although I'd prefer not to add a new name to the haskell ecosystem).I saw #45 after I'd written this, I'm afraid. Does anyone have any concerns about this implementation?