Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't hardcode flask version for testinfra checks #6641

Open
legoktm opened this issue Oct 17, 2022 · 1 comment
Open

Don't hardcode flask version for testinfra checks #6641

legoktm opened this issue Oct 17, 2022 · 1 comment
Labels
goals: sick CI hackathon help wanted Issues we would definitely appreciate volunteer help with

Comments

@legoktm
Copy link
Member

legoktm commented Oct 17, 2022

In 6e55b05 we bumped the the flask version but forgot to update the testinfra checks, necessitating b99469b.

flask is the only version that's hardcoded like this, we should see if we can avoid hardcoding it and reading it on the fly from securedrop-app-code-requirements.txt.
@zenmonkeykstop zenmonkeykstop added hackathon help wanted Issues we would definitely appreciate volunteer help with goals: sick CI labels Nov 2, 2022
@phershbe phershbe mentioned this issue Dec 7, 2022
Closed
@phershbe
Copy link

phershbe commented Dec 13, 2022 •
edited
Loading

@legoktm @zenmonkeykstop I've been working on this but am a little bit confused. Do we want to read the Flask version variable from https://github.com/freedomofpress/securedrop/blob/develop/securedrop/requirements/python3/securedrop-app-code-requirements.txt and create a variable to be used any place we have a Flask version in the YAML files in https://github.com/freedomofpress/securedrop/tree/develop/molecule/testinfra/vars?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
goals: sick CI hackathon help wanted Issues we would definitely appreciate volunteer help with
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@legoktm @zenmonkeykstop @phershbe