Do not depend on the Internet for keys_test.go

We now mock a PGP key server to provide the keys used during the testing, making it so that we do not need the Internet anymore for the testing of the PGP key import feature.
frebib · Mar 23, 2018 · 9c44363 · 9c44363
1 parent 69f4475
commit 9c44363
Show file tree

Hide file tree

Showing 8 changed files with 4,108 additions and 11 deletions.
diff --git a/keys_test.go b/keys_test.go
@@ -1,15 +1,37 @@
 package main
 
 import (
+	"bytes"
 	"fmt"
 	"io/ioutil"
+	"net/http"
 	"os"
+	"path"
+	"regexp"
 	"testing"
 
 	rpc "github.com/mikkeloscar/aur"
 	gopkg "github.com/mikkeloscar/gopkgbuild"
 )
 
+const (
+	// The default port used by the PGP key server.
+	gpgServerPort = 11371
+)
+
+func init() {
+	http.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) {
+		regex := regexp.MustCompile(`search=0[xX]([a-fA-F0-9]+)`)
+		matches := regex.FindStringSubmatch(r.RequestURI)
+		data := ""
+		if matches != nil {
+			data = getPgpKey(matches[1])
+		}
+		w.Header().Set("Content-Type", "application/pgp-keys")
+		w.Write([]byte(data))
+	})
+}
+
 func newPkg(basename string) *rpc.Pkg {
 	return &rpc.Pkg{Name: basename, PackageBase: basename}
 }
@@ -18,6 +40,28 @@ func newSplitPkg(basename, name string) *rpc.Pkg {
 	return &rpc.Pkg{Name: name, PackageBase: basename}
 }
 
+func getPgpKey(key string) string {
+	var buffer bytes.Buffer
+
+	if contents, err := ioutil.ReadFile(path.Join("testdata", "keys", key)); err == nil {
+		buffer.WriteString("-----BEGIN PGP PUBLIC KEY BLOCK-----\n")
+		buffer.WriteString("Version: SKS 1.1.6\n")
+		buffer.WriteString("Comment: Hostname: yay\n\n")
+		buffer.Write(contents)
+		buffer.WriteString("\n-----END PGP PUBLIC KEY BLOCK-----\n")
+	}
+	return buffer.String()
+}
+
+func startPgpKeyServer() *http.Server {
+	srv := &http.Server{Addr: fmt.Sprintf("127.0.0.1:%d", gpgServerPort)}
+
+	go func() {
+		srv.ListenAndServe()
+	}()
+	return srv
+}
+
 func TestFormatKeysToImport(t *testing.T) {
 	casetests := []struct {
 		keySet    pgpKeySet
@@ -111,12 +155,13 @@ func TestImportKeys(t *testing.T) {
 	if err != nil {
 		t.Fatalf("Unable to init test keyring %q: %v\n", keyringDir, err)
 	}
-
-	// Removing the leftovers.
 	defer os.RemoveAll(keyringDir)
 
 	config.GpgBin = "gpg"
-	config.GpgFlags = fmt.Sprintf("--homedir %s", keyringDir)
+	config.GpgFlags = fmt.Sprintf("--homedir %s --keyserver 127.0.0.1", keyringDir)
+
+	server := startPgpKeyServer()
+	defer server.Shutdown(nil)
 
 	casetests := []struct {
 		keys      []string
@@ -177,15 +222,11 @@ func TestCheckPgpKeys(t *testing.T) {
 	}
 	defer os.RemoveAll(keyringDir)
 
-	buildDir, err := ioutil.TempDir("/tmp", "yay-test-build-dir")
-	if err != nil {
-		t.Fatalf("Unable to init temp build dir: %v\n", err)
-	}
-	defer os.RemoveAll(buildDir)
-
-	config.BuildDir = buildDir
 	config.GpgBin = "gpg"
-	config.GpgFlags = fmt.Sprintf("--homedir %s", keyringDir)
+	config.GpgFlags = fmt.Sprintf("--homedir %s --keyserver 127.0.0.1", keyringDir)
+
+	server := startPgpKeyServer()
+	defer server.Shutdown(nil)
 
 	casetests := []struct {
 		pkgs      []*rpc.Pkg

diff --git a/testdata/keys/11E521D646982372EB577A1F8F0871F202119294 b/testdata/keys/11E521D646982372EB577A1F8F0871F202119294
@@ -0,0 +1,63 @@
+mQENBFNoLTkBCADXH3jKqmlGe+g54RIJ73YbqtSn1YCuZwSjdhG1nsvpglp8CZSd3ZwAUBRA
+rRttrWNFMQNNBBt/10JKCw5MTEYzSeDgoVXmrOKcWjC7JGK4/ezQP/i/lFGQkRIhP5gt9Op3
+j97ktx57qJChmqvGyfLm9RDRwadiM1HVXaEyqWD13lIZnNOhwcb0B3yYEu+rnXrWF4LrEkll
+8BQ2AHW78Moby2IhGalm6E3gHfTU6i/6pADGT7ME5VbCvMs4Bjk4HhYsxky1AyBHbHEsP+0d
+DSUbP+tXIet5EWthS1QFUvzNaxcTb+FQPQOo6jKh3jaYEiu5btCaS9zGhdHxK5TEI6KNABEB
+AAG0H1RvbSBTdGVsbGFyZCA8dG9tQHN0ZWxsYXJkLm5ldD6JATMEEAEIAB0WIQSjTtJi633S
+EwgMKOXUgYG0XhoskAUCWmcaMQAKCRDUgYG0XhoskMQdCACwH+D7RAlxJqCgk6tMOC3UTmVR
+Kg7bRYZ88NiR7Uj79E3h2/a4RFmqTVdY3L8lYdrDqfrJMT4aE/+K+GTLnoED2H/j/l1DuCqn
+RujXmhOY10OClF7IbqIBoSI9SP3pKpzpoxPE7PJFSxIhtSa61Rls02Z4monz+LoScQVmP3KT
+gksslRlFglT0e/e6ZWJ5sqNtllRm3v/yxhJ7N1CjPKgukbRcmMQ1wjxGFl7hzMDUOCP4aCsO
+JUKgMA3qtAqzcoASRg4yD/Nbw89nRe4dKjP/ftk6nPKMXfLhZkZliYv2wuebOrhWYy33jKrS
+9cD5LfcTLKtDadBkYpntsM4kVCd8iQEzBBABCAAdFiEE/aQwPpLUWm5kM7mBoUroEnNE6zgF
+AlpTtKsACgkQoUroEnNE6zh+HwgAnlN01PlgIPM9H6mHoUwcHmnugz4jopeg/z/rPDIPUtKX
+Fyh1v+J7R+a/dyPE8arvZGcYT2/r/owpWtqtU6PoQzUsRVl5yXI009+9taOPibXBkLuK6Uor
+4x1fHHhsDcqFkNl6JoIhV7ZKtosqwTcllEr7dZDteIi0f1pJtwowvtaYyHT3qi0JI1nwFVsm
+YmZmqwOo2268S/kYJ5nyxq/8rvttSXUXmA7MUdD0MxgZDNIL0zWIo9ExVY6B0o1L1eNENsGG
+UjPH6lk8D1Z+Yd5NlfX8kcwSFVKmOgLqtnmgEfIT/s70FtA86abF6m3Ftij1+35XqH+kOB3U
+g8ig/84Rg4kBOQQTAQIAIwUCU2gtOQIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJ
+EI8IcfICEZKUxQcIAJHBN281EV1Ulw3qFD1KsI0cJM9HCgiA3UQGErQOueRCSxSDPcy6sJ1E
+sveVozb+79Og6fwtaxtTxrt9O5gz6/xopBJ3hixr57+cKu7GEOGvED/0mr3zWpvVpHjH4SWX
+0lNeUT6XfQOcBFssPWtN5LH/IOR5Ebw8WJ6LOnbGrsq0sESJzyZYleL1X4rGNWqBI/5hnRHX
+FCEQNfqFyRY1tQoK4HXjINi+CSyRWoIEJW6iNXFkEtzEN3DbPjquQgddXYTyExDOR+vm7AGl
+95mMeqO5Ok9cyEZacT77CmHsEMAES3ku6A9oLvFH/9mhbywEWpTilQqua6s0x/JxOqTTQ6OJ
+AT8EEwECACkCGwMHCwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAUCU2p0qgUJA8SucQAKCRCP
+CHHyAhGSlJAxCACD+LVW+h35WDm0BdiwdmSk9S83FV9dkv/GrDz/vki8ArnUjdyqlYbcWjfK
+gNPU9oT/d3k1Bn0iXmAo7r3oGAaUlQh91IQT5yto1GNNFJWKHtuo/w+c+NxMe8YynrHHKeq7
+dQTPOG+qQgGv+LHJVg5WOEIDarRLXlyyu1ge/fPAwaDd5eCroTtX4oaNOmNeahRY0kGeu/nx
+mRyne4E0YTBVeAG8dZT6NFy0IoJGwRePdZDl7iWptUdYyPGGJr2zwsMFRnlnS82qeCEWog2w
+13REf4pmc8/wOUznGbyqJWgERvE9+NR7+0Pzn7DeeDS6sY42+/ApsTR1074iACsLSf7AiQE/
+BBMBAgApAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AFAld7B4kFCQX0DdAACgkQjwhx
+8gIRkpSO6Af/UxxkDh3wnpfeIfunBJSn2aq0lNlsONTky2PRodqAKfH6frGB/B+IEa4TYtG4
+4nqDrF+y6ObuBCRto7O3CphgVfVtbptkrtMeCG+Zq5d37dvKxozHJQ4EzCv7TARxkXtwT9cv
+zLQs/q1Pis7oNomLKTa0nK3DMY+W6VY9RPMD42+KOjG/H5A5CPu7IPX8QR+dBz6r1zge9Zzo
+VLCd9ngrFyK/CW+/jkEhaPu1HL2m2M/qY02vnR858Eyw/sS+H1Gt6Y/lkRCOCi7bmq+IwlkQ
+7WNfpUNcghSXCBb0FLeDIODt2VukSKTHF/FklsZ1ao3mK2RfodCX3lwfP05j9hZ7lIkBPwQT
+AQIAKQIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheABQJZUjJCBQkJUCMJAAoJEI8IcfIC
+EZKUp28IAMd2IPTTJQHSJaiAIaXA29ZFnPdd1O9+I1Xwa0xnDufqjTCHfB3WbUyYIE1n4WuT
+7USWXTCWi+hYbX+zWQYhRhyGHnl2p2BNlmIijfJ9iu42JRqOLVITfmakEHlgurY6Ol4RsyM7
+yttmElaCFXXRPiebqUDWSf8oEFcXj4vs25oSowNReVtZAQv014ziR2WGu5tKvb//8alvhMfz
+pUagxE9F7XcQAdJb57G0vlrHZIDvGcvVWlAnzi0zp0L8ZF51pHDRF45hURhQFr/2NkDQRWCP
+t07/d5N7BQYXrKgeydVCzBkrrzj9X0rSJOox7a0AsPySCQYeFBVTQQhuifWs4hGJAjMEEgEI
+AB0WIQSm5op4O95BdGcqQkHwXKpE5VGK/wUCWie6EQAKCRDwXKpE5VGK/zK7D/9/+tJ8XW+v
+go4lDdFVn0j1VFe+RUav5rGemUXsUqjaBR63Z8Msa90XfC0klI1t0FwK19yMRTeZFqKNexMV
+KkwpFkNdAS84f/z9DxLYyIULvATGEnBCotwN9j/zby8ATzu3uxAaWVjwW8WdOZZksyKvES1M
+LV/uuhVLlzPuHYdQu76BdwLmPdxt2DaWFs3HE8OWoZHRhrmXGv2+uvaEu9OAABCKz2zd3BcB
+1YxjCUvrfNOmAyJtpyZYRU9zCIC2NSfdMnvYcJ2hLA28QJdrLFC88aegFBXs4twWHNY7Pws5
++sTfRrq9R5hV83ElrMY33ALZ/x3hIlSWlqYvFD7bKEzDG2+0znlBV6AIGCa3gINtQdYw3kYC
+6v1AOZPdUUJKMbsjJqagsQncDrlOuijwEjJ4w/uiAbDpQOpDx95VMagte3XHtjNbRFBkvOFQ
+pXZeVK5ZW7RrQLS252HWXihwYTm3+prmDx+34+d1AwFYceegoTOD8qmDyR/b4Ujlyv9nMYxs
+gF9z4arQ3mwrC8LZZ+A0ZkpGnO89ydjh6YRqO7O/HqlCPam+YkHDra+A71BxzaVlL5EnVj8O
+OK6Zab5ZH+Y8S1r8cpyBH4dD7fL6W7iHtLuSF3rv8U6PoZuz0gzGNTNrzHiUFad6JxXOxVt2
+I6nXLl+FXTd35Ow8e49VRfKtCbkBDQRTaC05AQgA9D8qkysMobEFS8ZEl6alL6CUmkDwU3ok
+9wZndbSqmL9C6Pzix4rDLF+bhJJ4OF9blJWSZinjL31Hk7IpGn/99HlgjeWiplYg4o00NfD7
+FCGEIz0Llrf43Muu3C25qhWuP4QmJAd729k8x/5v+TGTQWLXl+DV0QEaP+g4y5EI5uHA8lxO
+MhZPkKo9IbtMZJIzIm9x2Ja7KCXU9wNW0+t2Dxgoo9A5LnwmVKmGwMw4CxcEej+pg+DYq+J4
+qVW1gtqwSzL4mXdiwYAcblSdSAtEijCYqtwEsz1GpeLb140yHub3QInTGJj4uWr2BKN+wYdB
+JCmLbrw4RYjFiIrnTVGzPQARAQABiQEfBBgBAgAJBQJTaC05AhsMAAoJEI8IcfICEZKU5MMI
+AJy5vfd2jFfoWPo3Kgn0r2oj9sTcxXQDgf4B54/mEbcfwqKEINw0n7fLVPyoEAZdiLsZJ8fl
+DA6u6Wp1hg2qvjWFFlZAx4XiRVlRhJfWuO+fkCeOS2wCaYppa8dnd8lz0SzRiJAepCeVUHTX
+feRw1iTLVRR6SmbJOqJM1cOceEoFNmvfY1B8/8drsFC1MGn+yj8kv+I4StW3+juwh8YjRe/W
+nF2Mr8kc3+v4m4mt+RtYuCsWiA6QcBQWH/ylks2EAKCYMevmZWSd994iGqQ157X4MDBiOZ/4
+rn7/vY/6CHwDWXVPLd6KoD8l79QggNCYWsDTp0h6XxGKqvL5OIwcQDQ=
+=/J5n