Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Connection Validation and Pool configuration #6233

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

tnleeuw
Copy link
Contributor

@tnleeuw tnleeuw commented Feb 5, 2024

(cherry picked from commit 281bf1e)

* Add Connection Pool Validation (#6119)
(Cherrypick from 8a26d34)
* PoolingJndiDataSourceFactory shouldn't check for DataSource to be XA or not XA (#6187)
* Try to determine if a datasource already does pooling (#6199)

Only works for non-XA datasources currently, for XA datasources we need to still consider what is best to do as many XA drivers already implement pooling even if it's not configured.

(cherry picked from commit 281bf1e)
@tnleeuw tnleeuw requested review from nielsm5 and jkosternl February 5, 2024 16:02
@tnleeuw tnleeuw self-assigned this Feb 5, 2024
@tnleeuw tnleeuw linked an issue Feb 5, 2024 that may be closed by this pull request
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

1 Security Hotspot
48.0% Coverage on New Code (required ≥ 65%)
B Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@nielsm5 nielsm5 merged commit c53a2da into 8.0-release Feb 5, 2024
10 of 12 checks passed
@nielsm5 nielsm5 deleted the issue/8.0/6117_JdbcConnPoolSettings branch February 5, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Db connections are left open in pool
3 participants