Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/cleanup JmsFacade/MessagingSource/MessagingSourceFactory #4390

Open
nielsm5 opened this issue Jan 20, 2023 · 0 comments
Open

Refactor/cleanup JmsFacade/MessagingSource/MessagingSourceFactory #4390

nielsm5 opened this issue Jan 20, 2023 · 0 comments

Comments

@nielsm5
Copy link
Member

nielsm5 commented Jan 20, 2023

Describe the issue
Right now the JMS Facade is a bit messy with both the MessagingSource, MessagingSourceFactory and the Facade doing JMS related things. The code should be cleaned up and tested. A check should be performed if the QCF is wrapped in a TransactionAwareConnectionFactoryProxy and like the TransactionalDbmsSupportAwareDataSourceProxy the metadata should be cached.
Also both MessagingSource#getPhysicalName() and JmsMessagingSourceFactory#getConnectionFactoryInfo(...) have methods to retrieve info about the QCF.

Wrapping the QCF in JmsMessagingSourceFactory should be moved to the QueueConnectionFactoryFactory.

The toString info, changed in pr #4481 and #4572 need to work as well...

Reporter
Niels

@nielsm5 nielsm5 assigned nielsm5 and unassigned nielsm5 Feb 16, 2023
@nielsm5 nielsm5 mentioned this issue Feb 16, 2023
4 tasks
@nielsm5 nielsm5 added this to the 7.9 milestone Feb 22, 2023
@nielsm5 nielsm5 modified the milestones: 7.9-RC1, 7.9 Oct 31, 2023
@nielsm5 nielsm5 modified the milestones: 7.9, 8.0, 8.1 Nov 27, 2023
@nielsm5 nielsm5 modified the milestones: 8.1, 8.2 Feb 26, 2024
@nielsm5 nielsm5 modified the milestones: 8.3, 8.2 Apr 29, 2024
@nielsm5 nielsm5 modified the milestones: 8.2, 8.3 Jul 3, 2024
@nielsm5 nielsm5 modified the milestones: 8.3, 8.4 Aug 4, 2024
@nielsm5 nielsm5 modified the milestones: 9.0, 9.1 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant