Adding e2e tests to CI #2704
Open
Adding e2e tests to CI #2704
+408
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgperry
force-pushed
the
feature/ci
branch
2 times, most recently
from
e68c576
to
de0399f
Compare
mattgperry
force-pushed
the
feature/ci
branch
2 times, most recently
from
1cb6e49
to
112483b
Compare
mattgperry
force-pushed
the
feature/ci
branch
from
3df5cf3
to
8500196
Compare
nvh
reviewed
Sep 25, 2024
| @@ -0,0 +1,207 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
nvh
reviewed
Oct 1, 2024
Comment on lines
+21
to
+25
| "jest-junit", | ||
| { | ||
| "outputDirectory": "../../test_reports", | ||
| "outputName": "framer-motion.xml" | ||
| } |
There was a problem hiding this comment.
Are these still outputting the junit test reports to the console? Or did we fix that too?
nvh
reviewed
Oct 1, 2024
| @@ -445,7 +446,7 @@ describe("AnimatePresence", () => { | |||
| }) | |||
|
|
|||
| test("Fast animations with wait render the child content correctly (strict mode disabled)", async () => { | |||
| const promise = new Promise<boolean>((resolve) => { | |||
| await new Promise<boolean>((resolve) => { | |||
There was a problem hiding this comment.
In theory if this reslove with false, we would not catch this now.
If it rejects, than the await throws and that will fail the test, right?
nvh
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves E2E tests to CircleCI, with a check for passing tests on
mainbefore publish.