chore(forge): enforce common::shell for forge crate
#9231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy and
yash-atreya
as code owners
|
Tagging as |
|
Stalling issue resolved by Dani in #9245 |
mattsse
approved these changes
Nov 4, 2024
leovct
pushed a commit
to leovct/foundry
that referenced
this pull request
Nov 6, 2024
…#9231) * enforce common shell for forge crate * revert clippy.toml * fix tests * avoid empty printlns * fix missed eprint / print * avoid style regression
rplusq
pushed a commit
to rplusq/foundry
that referenced
this pull request
Nov 29, 2024
…#9231) * enforce common shell for forge crate * revert clippy.toml * fix tests * avoid empty printlns * fix missed eprint / print * avoid style regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Enforces
common::shellas added in #9109 for theforgecrateIncludes minor fix preferring prepending / appending
\nin favor of an emptysh_println!()Adds
#[allow(clippy::disallowed_macros)]to test macros as preparation for enabled clippy enforcement allow you to still useprintln, etc.. in tests. In some specific cases you may need to add#[allow(clippy::disallowed_macros)]above helpers.Solution
Splits out the enforcement of the common shell per binary / large crate to avoid huge diffs making reviews easier