Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add foundry_common::shell to unify log behavior #9109

Merged
merged 46 commits into from
Oct 23, 2024
Merged

feat: add foundry_common::shell to unify log behavior #9109

Changes from 1 commit
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
2b7bd49
replace existing shell::println, add macros
zerosnacks Oct 4, 2024
9b6d7bf
finish replacing shell::println
zerosnacks Oct 4, 2024
95569c6
remove p_println
zerosnacks Oct 4, 2024
4113fbd
remove redundant quiet or silent variables
zerosnacks Oct 4, 2024
74b2349
install global shells in binaries
zerosnacks Oct 4, 2024
757085a
CastArgs -> Cast, Cast -> CastInstance
zerosnacks Oct 4, 2024
8b525c2
fix tests, always initialize Mutex::new(Shell::new()) on initial acce…
zerosnacks Oct 4, 2024
9544177
merge in master
zerosnacks Oct 11, 2024
37463fd
revert .quiet(true)
zerosnacks Oct 11, 2024
43c9c07
add back quiet
zerosnacks Oct 11, 2024
df1968c
Merge branch 'master' into zerosnacks/common-shell-2
zerosnacks Oct 14, 2024
b3bf6f4
undo CastInstance -> Cast, Cast -> CastArgs
zerosnacks Oct 14, 2024
69603dd
add global --json format
zerosnacks Oct 15, 2024
bffc2bb
use global --json flag
zerosnacks Oct 15, 2024
aa14ec8
Merge branch 'master' into zerosnacks/common-shell-2
zerosnacks Oct 15, 2024
59cb879
revert sequence / multisequence save silent mode
zerosnacks Oct 15, 2024
59da13e
fix failing tests
zerosnacks Oct 15, 2024
624604a
merge in master
zerosnacks Oct 15, 2024
4c37387
fix tests
zerosnacks Oct 15, 2024
133180b
fix tests
zerosnacks Oct 15, 2024
06c5818
replace cli_warn with sh_warn
zerosnacks Oct 15, 2024
9c89ce7
use shell json directly instead of passing in
zerosnacks Oct 15, 2024
05571e1
clean up, document print modes in respect to --quiet flag
zerosnacks Oct 15, 2024
b359478
group shell options under display options
zerosnacks Oct 15, 2024
ae0e62e
revert global --json flag
zerosnacks Oct 16, 2024
b70d7e4
remove redundant import
zerosnacks Oct 16, 2024
d002fdf
fix: quiet
zerosnacks Oct 16, 2024
236dd18
remove faulty argument conflict test as there is no way to currently …
zerosnacks Oct 16, 2024
e5044f1
add back conflicts_with quiet flag, global args w/ conflicts_with wor…
zerosnacks Oct 16, 2024
5755a3c
remove yellow()
zerosnacks Oct 16, 2024
e94fa11
Apply suggestions from code review
zerosnacks Oct 16, 2024
71372a9
Merge branch 'zerosnacks/common-shell-2' of github.com:foundry-rs/fou…
zerosnacks Oct 16, 2024
4415957
fix deprecated terminal_size method
zerosnacks Oct 16, 2024
488a436
revert quiet flag, fix os:fd import for windows
zerosnacks Oct 16, 2024
7682ac0
add replacing tests, add back quiet conflicting flag
zerosnacks Oct 16, 2024
0609af9
make output windows compatible
zerosnacks Oct 16, 2024
d2c81fb
to avoid visual regression, style warning message content in yellow, …
zerosnacks Oct 17, 2024
c4aa9c5
fix docs links
zerosnacks Oct 17, 2024
765daee
Merge branch 'master' into zerosnacks/common-shell-2
zerosnacks Oct 17, 2024
3f9cd29
Merge branch 'master' into zerosnacks/common-shell-2
zerosnacks Oct 17, 2024
82c2da2
fix junit throwing mixed content on warnings, avoid modifying global …
zerosnacks Oct 17, 2024
03a11d7
remove set_verbosity shell helper, redundant
zerosnacks Oct 17, 2024
73c2112
revert default .expect on printing, prefer passing. revert message st…
zerosnacks Oct 21, 2024
c4f8d4d
fix doc test, fix formatting
zerosnacks Oct 21, 2024
6f6b280
fix merge conflict
zerosnacks Oct 23, 2024
efce06a
fix merge issues
zerosnacks Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove yellow()
  • Loading branch information
@zerosnacks
zerosnacks committed Oct 16, 2024
commit 5755a3c0a759c35b7a051a3bb079d37fa8522357
5 changes: 1 addition & 4 deletions crates/forge/bin/cmd/install.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,7 @@ impl DependencyInstallOpts {
sh_println!("Missing dependencies found. Installing now...\n");
self.no_commit = true;
if self.install(config, Vec::new()).is_err() {
sh_warn!(
"{}",
"Your project has missing dependencies that could not be installed.".yellow()
)
sh_warn!("{}", "Your project has missing dependencies that could not be installed.")
}
true
} else {
Expand Down