-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deps): Move to Alloy ABI encoding/decoding & alloy types #5986
Merged
Merged
Changes from all commits
Commits
Show all changes
83 commits
Select commit
Hold shift + click to select a range
ee18e87
feat: find and replace all ethers_solc mentions outside anvil
Evalir 6c6aa4e
chore: keep resolving errors as fuzz is getting migrated
Evalir f33e414
feat: fuzz/trace changes
Evalir a8bb5b0
feat: partial trace migration
Evalir adc2786
chore: use temporal sol! macro in diff file for decode migration
Evalir 8bc67d2
feat: use proptest traits instead of custom impl
Evalir 65f0918
chore: address comments
Evalir a54005a
chore: remove alloy console bindings
Evalir 2c70bd9
feat: introduce foundry-block-explorers
Evalir 55ad9bf
chore: partial common abi helpers migration
Evalir 94fb974
feat: partial decode migration
Evalir b3935cc
feat: re-introduce block-explorers
Evalir 8737a52
feat: fix compiler errors
Evalir 988e756
chore
Evalir 5b8c207
chore: tentative inspector migration
Evalir bd2fbb3
Merge branch 'master' into evalir/introduce-foundry-compilers
Evalir 3c3b35c
feat: switch to using static decoder to decode errors
Evalir 7484d3b
chore: clippy
Evalir 3adebd5
feat: migrate trace types temporarily
Evalir c44e796
chore: replace ethers tracing types for local tracing types
Evalir b51f741
chore: rebase
Evalir bb68371
fix: handle decoding with static decoder, tests
Evalir 079c879
chore: use JsonAbi for console/hardhat/hevm abis
Evalir d9207b2
chore: add todo
Evalir efd0323
chore: replace types downstream and remove glue
Evalir de459d4
feat: fix last evm issues, start fixing downstream type issues
Evalir 8356303
chore: cargo
Evalir bcb57a2
chore: more downstream error fixes
Evalir 4d4255b
chore: fix test files
Evalir 5f145b7
chore: more downstream fixes
Evalir 90d5b05
chore: fmt
Evalir 3ea011c
feat: migrate unit utils, replace
Evalir 48832e5
chore: fix tests, fmt
Evalir 2cefb6f
compiles
Evalir 6bef6ad
clippy
Evalir 170f5e6
chore: clippy
Evalir d8e54b9
Merge branch 'master' into evalir/introduce-foundry-compilers
Evalir 5b404e0
chore: last fixes
Evalir 2dbe680
chore: update block explorers
Evalir ea9b980
chore: actually coerce values correctly
Evalir a1b7442
chore: fix broken test
Evalir 23e281d
chore: fix estimation test, parse values as alloy nums
Evalir bdc95bb
chore: fix abi parsing
Evalir 8507f92
chore: selector tests
Evalir e42aeba
chore: fix more tests, remove more glue
Evalir dc05ee5
chore: properly decode logs
Evalir 944174a
chore: use selector_type to handle tuples correctly
Evalir 4b2f0ea
chore: clippy and fix another test
Evalir f297ace
chore: fix remaining abi tests
Evalir 403de57
chore: use proptest traits for fuzzer
Evalir ffcb558
more test fixes ongod
Evalir 2c64c3d
clippy
Evalir ef21ace
chore: use abigen for console logs for now
Evalir 99c228d
fix: generate valid values in fuzzer
Evalir ebf9523
chore: clippy
Evalir 92c6b5a
chore: readd settings
Evalir e3dfa8b
chore: various fixes
Evalir da9b483
chore: fix script arguments decoding
Evalir adc940a
chore: fix more tests
Evalir b1f5ff7
chore: last ots fixes
Evalir 0dbcf71
fix: decoding
Evalir 0e2c954
chore: clippy
Evalir 4d9ea34
chore: fmt
Evalir 9b5c45c
chore: fix deny check
Evalir 1d1dc01
chore: deny fixes
Evalir e50cc48
chore: force default features off
Evalir 5ce86fe
Merge branch 'master' into evalir/introduce-foundry-compilers
Evalir 5c37c4b
chore: update block-explorers
Evalir 30b2295
chore: doc fixes
Evalir cd25d3b
chore: ignore invariant storage test due to flakyness
Evalir 6c88473
chore: update foundry-block-explorers
Evalir fb7bd39
chore: cleanup, config migration
Evalir 5500c14
chore: resolve comments, more cleanup, remove unwraps
Evalir e4e347a
chore: remove last mentions of ethers::etherscan
Evalir 823a6e3
chore: remove ethers-solc feat
Evalir 27f107a
Merge branch 'master' into evalir/introduce-foundry-compilers
Evalir cf7fdce
chore: use alloy master again
Evalir 371e817
chore: readd NameOrAddress
Evalir 4e4e4c1
chore: clippy/fmt
Evalir bcd565f
chore: readd support on storage
Evalir bd3e506
fix: add remappings on settings
Evalir f958758
chore: address comments (remove create2, noop map, remove eyre from d…
Evalir 963234d
chore: use NameOrAddress
Evalir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the path towards removing these patches? why do we need them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main offender is
foundry-block-explorers
needing the chain enum from ethers. Once we havealloy-rs/chains
we can publish both block explorers and compilers and remove the patches. For alloy, we need a newer release with all the new features we're using off of master.