Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add red border to TextViews of screen for MPU925X #2586

Merged
merged 2 commits into from
Dec 21, 2024
Merged

fix: add red border to TextViews of screen for MPU925X #2586

merged 2 commits into from
Dec 21, 2024

Conversation

marcnause
Copy link
Contributor

@marcnause marcnause commented Dec 16, 2024 •
edited
Loading

Fixes https://github.com/fossasia/pslab-android/issues/

Fixes #2585

Changes

  • changed width of TextViews to make red borders visible
  • introduce uniform width and height for TextViews in sensor screens and use i where possible

Screenshots / Recordings

Checklist:

  • No hard coding: I have used resources from strings.xml, dimens.xml and colors.xml without hard coding any value.
  • No end of file edits: No modifications done at end of resource files strings.xml, dimens.xml or colors.xml.
  • Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
  • No extra space: My code does not contain any extra lines or extra spaces than the ones that are necessary.

Summary by Sourcery

Bug Fixes:

  • Adjust the width of TextViews in the MPU925X sensor screen layout to ensure red borders are visible.

@sourcery-ai Sourcery AI
Copy link

sourcery-ai bot commented Dec 16, 2024 •
edited
Loading

Reviewer's Guide by Sourcery

This PR fixes the visibility of red borders around TextViews in the MPU925X sensor screen by setting explicit fixed widths instead of wrap_content. The changes are purely layout-related, affecting the visual presentation of sensor readings.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Modified TextView width properties to ensure border visibility
  • Changed layout_width from wrap_content to 80dp for all sensor reading TextViews
  • Affected TextViews include acceleration (ax, ay, az), temperature, and gyroscope (gx, gy, gz) readings
 app/src/main/res/layout/sensor_mpu925x.xml
Minor XML attribute reordering
  • Reordered srcCompat and scaleType attributes in the play button ImageButton
 app/src/main/res/layout/sensor_mpu925x.xml

Assessment against linked issues

Issue Objective Addressed Explanation
#2585 Add red border around TextViews in the MPU925X sensor screen to match other sensor screens ✅

Possibly linked issues

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Dec 16, 2024
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @marcnause - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider moving the hardcoded '80dp' width to a dimension resource in dimens.xml to improve maintainability and support different screen sizes better.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 16, 2024 •
edited
Loading

Build successful. APKs to test: https://github.com/fossasia/pslab-android/actions/runs/12362517406/artifacts/2328978447

@AsCress
Copy link
Contributor

AsCress commented Dec 21, 2024

@marcnause This can be merged.

@marcnause marcnause merged commit 07cff17 into fossasia:development Dec 21, 2024
3 checks passed
@marcnause marcnause deleted the issue2585 branch December 21, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@AsCress AsCress AsCress approved these changes

@CloudyPadmal CloudyPadmal CloudyPadmal approved these changes

Assignees
No one assigned
Labels
Instrument: Sensors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Layout of screen for MPU925X is missing red border around TextViews
3 participants
@marcnause @AsCress @CloudyPadmal