Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Country Phone Codes #47

Open
sivajyothika opened this issue May 18, 2024 · 5 comments · May be fixed by #75
Open

Country Phone Codes #47

sivajyothika opened this issue May 18, 2024 · 5 comments · May be fixed by #75
Assignees
@sivajyothika
Labels
gssoc level2

Comments

@sivajyothika
Copy link

Hi , For country , I want to add one more API called country phone code which gives the phone codes of countries example (India : 91 , USA : 1,UK : 44 )

This is the approach :

method: get
title: Country Phone Code Dictionary
desc: Fetch the country phone code dictionary where country names are keys and the respective phone codes are the values corresponding to the keys.
path: country/phonecodes
@ashitaprasad
Copy link
Member

Yes you can add it .. we already have the data in foss42-core
https://github.com/foss42/foss42-core/blob/c38af576f2311c4185bec8c17f72042ead453124/foss42/data/geo/country.py#L266

@sivajyothika
Copy link
Author

Yes you can add it .. we already have the data in foss42-core https://github.com/foss42/foss42-core/blob/c38af576f2311c4185bec8c17f72042ead453124/foss42/data/geo/country.py#L266

Sure will do that

@lassmara
Copy link

Please assign me this issue.

@shashbh18
Copy link

I would love to work on it.Please assign this issue to me.

@bro-maanii bro-maanii linked a pull request Jun 25, 2024 that will close this issue
Open
@bro-maanii
Copy link

Hi Ashitaprasad

I noticed that the implementation of the country phone code API requested on May 18 hasn't been completed yet. To help move things forward, I have created a pull request that addresses this.

The new API endpoint I've added is:
Method: GET
Title: Country Phone Code Dictionary
Description: Fetches the country phone code dictionary where country names are keys and the respective phone codes are the values corresponding to the keys.
Path: /country/phonecodes

Please review the pull request at your earliest convenience and let me know if there are any changes or improvements needed.
Thank you!

Best regards,
Eman Ali

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sivajyothika sivajyothika

Labels
gssoc level2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PhoneCode API #47 bro-maanii/api
5 participants
@ashitaprasad @sivajyothika @bro-maanii @shashbh18 @lassmara