Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MethodLength to 40 #4173

Closed
wants to merge 11 commits into from
Closed

Update MethodLength to 40 #4173

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ba8b849
Update MethodLength to 40
maestromac Oct 1, 2019
9bcbb54
Merge branch 'master' into mac/misc/update-cc
maestromac Oct 9, 2019
bbf282a
Unexclude spec/ from CodeClimate
maestromac Oct 9, 2019
1f05e54
Refactor long line
maestromac Oct 9, 2019
eb06690
Extract json content to jbuilder
maestromac Oct 9, 2019
415514a
Make things a bit shorter
maestromac Oct 9, 2019
55ecd4e
Add excluded file for line metric
maestromac Oct 9, 2019
b13a069
Use proper rendering
maestromac Oct 9, 2019
0a622be
Apply "Rule of three" to code dupes
maestromac Oct 10, 2019
3125665
Exclude specs from line-lengths metric
maestromac Oct 10, 2019
dcb1cec
Undo check exclude_pattern
maestromac Oct 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .codeclimate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ checks:
method-lines:
enabled: true
config:
threshold: 25
threshold: 40
nested-control-flow:
enabled: true
config:
Expand Down
3 changes: 2 additions & 1 deletion .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ Metrics/PerceivedComplexity:
Metrics/MethodLength:
Description: 'Avoid methods longer than 10 lines of code.'
StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#short-methods'
Enabled: false
Enabled: true
Max: 40

Metrics/ParameterLists:
Description: 'Avoid parameter lists longer than three or four parameters.'
Expand Down