Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an article exclusion list to Billboards #19280

Merged
merged 18 commits into from
Apr 5, 2023
Merged

Add an article exclusion list to Billboards #19280

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
75dc878
Add exclude_article_ids int array
jaw6 Mar 30, 2023
99ca65c
Add specs, normalize inputs better
jaw6 Mar 30, 2023
ef7532b
Add to form & controller
jaw6 Mar 30, 2023
14a969f
Add exclude_article_ids to DisplayAd API
jaw6 Mar 30, 2023
d9a61db
Use exclude_article_ids in query
jaw6 Mar 30, 2023
819aca7
Rubocop
jaw6 Mar 30, 2023
bafc978
Comment typo
jaw6 Mar 30, 2023
85ed451
Tweak rspec example length config
jaw6 Mar 30, 2023
05d5512
Arguments all the way down
jaw6 Mar 30, 2023
e3c6260
Typo
jaw6 Mar 30, 2023
c1ba42a
Update spec/requests/api/v1/docs/display_ads_spec.rb
jaw6 Mar 31, 2023
19b03fd
Merge branch 'main' into jaw6/display_ad_article_exclusion
jaw6 Mar 31, 2023
2fff253
Update spec/requests/api/v1/docs/display_ads_spec.rb
jaw6 Mar 31, 2023
8f5acff
Swagger schema for Display Ad
jaw6 Mar 31, 2023
29ec75a
Merge branch 'main' into jaw6/display_ad_article_exclusion
jaw6 Apr 3, 2023
fbc949e
Merge branch 'main' into jaw6/display_ad_article_exclusion
jaw6 Apr 3, 2023
7a89fa0
Merge remote-tracking branch 'origin/main' into jaw6/display_ad_artic…
jaw6 Apr 4, 2023
0b992c3
Merge branch 'main' into jaw6/display_ad_article_exclusion
jaw6 Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into jaw6/display_ad_article_exclusion
  • Loading branch information
@jaw6
jaw6 authored Apr 3, 2023
commit 29ec75ad1a3332fb2f77432630f5a3a42b3650d6

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.