Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate namelist entry (Rfractur 0x211C) #5199

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove duplicate namelist entry (Rfractur 0x211C) #5199

wants to merge 1 commit into from

Conversation

12Me21
Copy link

@12Me21 12Me21 commented Feb 10, 2023

namelist.c has a duplicate entry in psaltnames:
line 20085: { "Rfractur", 0x211c, 0 },
line 20712: { "Rfractur", 0x211C, 0 },

Type of change

  • Non-breaking change

@iorsh
Copy link
Contributor

iorsh commented Feb 5, 2024

Quite a lot of names are appearing twice in psaltnames. For example, Shcha. I agree this is suboptimal, but does it cause some real issue? Glyph name selector in "Glyph Info" dialog seems to filter out duplicate entries.

@iorsh
Copy link
Contributor

iorsh commented Feb 25, 2024

This change doesn't seem useful to me. There are many duplications in psaltnames, and they don't seem to cause any undesired effects.

skef
skef reviewed Feb 25, 2024
View reviewed changes
Copy link
Contributor

@skef skef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have mixed feelings about this sort of PR. On the one hand merging this change would probably be fine. On the other, this is not a systematic solution to duplication (there are other duplicated values), and there could be a (perhaps dubious) rationale for the duplication: the comment indicates these are copied from another source, and maybe it makes sense to keep the copied values grouped together, even at the cost of some duplication.

I think for now I'd rather leave things as they are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skef skef skef left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@12Me21 @iorsh @skef