Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: add flag for number of glyphs per proto #37

Open
eigenfoo opened this issue Jun 10, 2019 · 2 comments
Open

ENH: add flag for number of glyphs per proto #37

eigenfoo opened this issue Jun 10, 2019 · 2 comments
Labels
discussion Feedback and discussion is needed

Comments

@eigenfoo
Copy link
Member

Following #36, knead saves each glyph into its own proto.

  1. Is there a use case where we would want multiple glyphs per proto? (This could be controlled by an optional flag).

  2. If so, how do we determine which glyphs go into which proto? Do we want protos of only one character, or only one font, or randomly shuffled? Should this be controlled by another flag?
@eigenfoo eigenfoo added the discussion Feedback and discussion is needed label Jun 10, 2019
@eigenfoo
Copy link
Member Author

Btw, it seems to me that the num_examples flag is actually broken in our code.

It looks like the code we have doesn't actually split the different glyphs from a font into different protos: it always saves one glyph per proto, but skips fonts.

@eigenfoo
Copy link
Member Author

Furthermore, if each proto contains a batch of protos, we will need to deal with padding...

@eigenfoo eigenfoo modified the milestone: v0.2.0 Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion Feedback and discussion is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eigenfoo