Skip to content

Commit

Permalink
fix: ensure the 'required' property is included as needed
Browse files Browse the repository at this point in the history
  • Loading branch information
psanders committed Dec 27, 2024
1 parent d91a20a commit cd2ccdd
Show file tree
Hide file tree
Showing 9 changed files with 22 additions and 12 deletions.
2 changes: 1 addition & 1 deletion config/assistant.example.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"conversationSettings": {
"firstMessage": "Hello, this is Emma from La Bella Ristorante. How are you today?",
"firstMessage": "Hello, this is Enma from La Bella Ristorante. How are you today?",
"systemTemplate": "[Role]\n\nYou are a voice agent designed to facilitate fluid and engaging conversations with users. Your primary role is to provide relevant and actionable information related about \"La Bella Ristorante\", assist with problem-solving, and maintain a coherent conversational flow. Always strive to be concise but informative, ensuring user satisfaction with each interaction.\n\n[Tone and Voice]\n\n- Maintain a friendly professional tone in all conversations\n- Adapt your responses based on the user's emotional state. If they seem confused, frustrated empathy, encouragement\n- Use human-like speech patterns to ensure the conversation feels smooth and engaging (e.g., avoid overly formal or robotic language)\n\n[Conversation Constraints]\n\nUse the following guidelines to ensure effective and engaging conversations:\n\n- Keep responses concise and conversational - aim for short sentence\n- When discussing sensitive or personal information, maintain a neutral, professional tone to ensure user comfort\n- Ensure that conversations remain focused on the topic at hand, but be flexible enough to handle related follow-up questions\n- When asked a question you don't know the answer to, tell you don't and offer to transfer the user to a human agent if necessary\n- Avoid using emojis, line-breaks, or other non-verbal communication in your responses\n\n[Contextual Understanding]\n\n- Leverage previous user inputs to contextualize your responses. For example, if the user mentioned a recent issue refer to it in your responses.\n- Ensure your suggestions are situationally appropriate to the context of the conversation.\n\n[Safety and Privacy]\n\n- You should refer the user to 911 or emergency services if they are in immediate danger or require urgent assistance.\n\n[Available Tools]\n\nYou have access to the following tools and capabilities:\n\n- Knowledge Base: User the knowledge base to provide information about the menu\n- Use the `getAvailableTimes` tool to check the availability of the user\n- User the `bookReservation` tool to help users book appointments or reservations\n- When the user says goodbye or similar closing phrases, you can use the `hangup` tool to end the conversation\n- When the user wants to speak to a human agent, you can use the `transfer` tool to transfer the conversation to a human agent",
"goodbyeMessage": "Goodbye! Have a great day!",
"systemErrorMessage": "I'm sorry, but I seem to be having trouble. Please try again later.",
Expand Down
4 changes: 2 additions & 2 deletions docs/early-access/link-twilio-number.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ Your output should show the newly created application. Here is an example of wha

```bash
REF NAME TYPE ENDPOINT
3e61ecb7-a1b6-4a93-84c3-4f1979165bca Emma at Bella Ristorante EXTERNAL 2.tcp.ngrok.io:19301
3e61ecb7-a1b6-4a93-84c3-4f1979165bca Enma at Bella Ristorante EXTERNAL 2.tcp.ngrok.io:19301
c495ee94-b93e-4ad1-b8bb-716833914c57 Julian at Papaton EXTERNAL 3.tcp.ngrok.io:59421
dbdb871b-e701-4080-b91b-d62b79b7050d Peters AI Assistant EXTERNAL 6.tcp.ngrok.io:49705
```
Expand Down Expand Up @@ -90,7 +90,7 @@ Your output should show the newly linked Twilio number. Here is an example of wh

```bash
REF NAME TEL URL
131ff7f4-8359-41a6-b701-02283ecdda9b Emma at Bella Ristorante tel:+19842051452 (US)
131ff7f4-8359-41a6-b701-02283ecdda9b Enma at Bella Ristorante tel:+19842051452 (US)
347b0fd8-97d6-4f3c-a923-a76ab5c7bf4f Julian at Ridesgur tel:+18456134823 (US)
f8c0c4e4-49f3-46ba-9cdb-982729cfc8b9 Peter's AI Assistant tel:+18559473625 (US)
```
Expand Down
5 changes: 4 additions & 1 deletion mods/ctl/src/commands/applications/get.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@ export default class Get extends AuthenticatedCommand<typeof Get> {
"retrieve details of an Application by reference";
static override readonly examples = ["<%= config.bin %> <%= command.id %>"];
static override readonly args = {
ref: Args.string({ description: "The Application to show details about" })
ref: Args.string({
description: "The Application to show details about",
required: true
})
};

public async run(): Promise<void> {
Expand Down
5 changes: 4 additions & 1 deletion mods/ctl/src/commands/applications/update.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@ export default class Update extends AuthenticatedCommand<typeof Update> {
"modify the configuration of an Application";
static override readonly examples = ["<%= config.bin %> <%= command.id %>"];
static override readonly args = {
ref: Args.string({ description: "the Application to update" })
ref: Args.string({
description: "the Application to update",
required: true
})
};

public async run(): Promise<void> {
Expand Down
5 changes: 4 additions & 1 deletion mods/ctl/src/commands/secrets/get.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@ export default class Get extends AuthenticatedCommand<typeof Get> {
"retrieve details of a Secret by reference";
static override readonly examples = ["<%= config.bin %> <%= command.id %>"];
static override readonly args = {
ref: Args.string({ description: "The Secret to show details about" })
ref: Args.string({
description: "The Secret to show details about",
required: true
})
};

public async run(): Promise<void> {
Expand Down
2 changes: 1 addition & 1 deletion mods/ctl/src/commands/secrets/update.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export default class Update extends AuthenticatedCommand<typeof Update> {
"modify the value or metadata of a Secret";
static override readonly examples = ["<%= config.bin %> <%= command.id %>"];
static override readonly args = {
ref: Args.string({ description: "the Secret to update" })
ref: Args.string({ description: "the Secret to update", required: true })
};

public async run(): Promise<void> {
Expand Down
7 changes: 4 additions & 3 deletions mods/ctl/src/commands/sipnet/numbers/get.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,17 @@ import { Args } from "@oclif/core";
import cliui from "cliui";
import moment from "moment";
import { AuthenticatedCommand } from "../../../AuthenticatedCommand";
import { getConfig } from "../../../config";
import { CONFIG_FILE } from "../../../constants";
import { Application } from "@fonoster/types";

export default class Get extends AuthenticatedCommand<typeof Get> {
static override readonly description =
"retrieve details of a Number by reference";
static override readonly examples = ["<%= config.bin %> <%= command.id %>"];
static override readonly args = {
ref: Args.string({ description: "the Number to show details about" })
ref: Args.string({
description: "the Number to show details about",
required: true
})
};

public async run(): Promise<void> {
Expand Down
2 changes: 1 addition & 1 deletion mods/ctl/src/commands/sipnet/numbers/update.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export default class Update extends AuthenticatedCommand<typeof Update> {
static override readonly description = "modify the configuration of a Number";
static override readonly examples = ["<%= config.bin %> <%= command.id %>"];
static override readonly args = {
ref: Args.string({ description: "the Number to update" })
ref: Args.string({ description: "the Number to update", required: true })
};

public async run(): Promise<void> {
Expand Down
2 changes: 1 addition & 1 deletion mods/ctl/src/commands/sipnet/trunks/update.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export default class Update extends AuthenticatedCommand<typeof Update> {
static override readonly description = "modify the configuration of a Trunk";
static override readonly examples = ["<%= config.bin %> <%= command.id %>"];
static override readonly args = {
ref: Args.string({ description: "the Trunk to update" })
ref: Args.string({ description: "the Trunk to update", required: true })
};

public async run(): Promise<void> {
Expand Down

0 comments on commit cd2ccdd

Please sign in to comment.