Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(win): backdrop having bright cell at top right #400

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

chrisgrieser
Copy link
Contributor

The bug

backdrop displays a bright cell at the top left. upon investigation, I figured out that it's created by the user's colorcolumn setting also being applied to the backdrop.

The fix

Disable colorcolumn for the backdrop window.

Screenshots

before
Pasted image 2024-12-27 at 14 16 40@2x

after
Pasted image 2024-12-27 at 14 17 14@2x

@github-actions github-actions bot added the win label Dec 27, 2024
@folke folke merged commit 373d0f9 into folke:main Dec 31, 2024
9 checks passed
@folke
Copy link
Owner

folke commented Dec 31, 2024

ty!

folke pushed a commit that referenced this pull request Jan 5, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.12.0](v2.11.0...v2.12.0)
(2025-01-05)


### Features

* **debug:** system & memory metrics useful for debugging
([cba16bd](cba16bd))
* **input:** disable completion engines in input
([37038df](37038df))
* **scope:** disable treesitter blocks by default
([8ec6e6a](8ec6e6a))
* **statuscolumn:** allow changing the marks hl group. Fixes
[#390](#390)
([8a6e5b9](8a6e5b9))
* **util:** `Snacks.util.ref`
([7383eda](7383eda))
* **util:** throttle
([737980d](737980d))
* **win:** `Snacks.win:border_size`
([4cd0647](4cd0647))
* **win:** `Snacks.win:redraw`
([0711a82](0711a82))
* **win:** `Snacks.win:scroll`
([a1da66e](a1da66e))
* **win:** allow setting `desc` for window actions
([402494b](402494b))
* **win:** better dimension calculation for windows (use by upcoming
layouts)
([cc0b528](cc0b528))
* **win:** top,right,bottom,left borders
([320ecbc](320ecbc))


### Bug Fixes

* **dashboard:** hash dashboard terminal section caching key to support
long commands ([#381](#381))
([d312053](d312053))
* **debug:** make debug.inpect work in fast events
([b70edc2](b70edc2))
* **debug:** make sure debug can be required in fast events
([6cbdbb9](6cbdbb9))
* **indent:** allow rendering over blank lines. Fixes
[#313](#313)
([766e671](766e671))
* **indent:** better way to deal with `breakindent`. Fixes
[#329](#329)
([235427a](235427a))
* **indent:** breakdinent
([972c61c](972c61c))
* **indent:** correct calculation of partial indent when leftcol > 0
([6f3cbf8](6f3cbf8))
* **indent:** do animate check in bufcall
([c62e7a2](c62e7a2))
* **indent:** don't render scopes in closed folds. Fixes
[#352](#352)
([94ec568](94ec568))
* **indent:** off-by-one for indent guide hl group
([551e644](551e644))
* **indent:** repeat_linbebreak only works on Neovim >= 0.10. Fixes
[#353](#353)
([b93201b](b93201b))
* **indent:** simplify indent guide logic and never overwrite blanks.
Fixes [#334](#334)
([282be8b](282be8b))
* **indent:** typo for underline
([66cce2f](66cce2f))
* **indent:** use space instead of full blank for indent offset. See
[#313](#313)
([58081bc](58081bc))
* **input:** change buftype to prompt. Fixes
[#350](#350)
([2990bf0](2990bf0))
* **input:** make sure to show input window with a higher zindex of the
parent window (if float)
([3123e6e](3123e6e))
* **input:** refactor for win changes and ensure modified=false. Fixes
[#403](#403). Fixes
[#402](#402)
([8930630](8930630))
* **input:** use correct highlight group for input prompt
([#328](#328))
([818da33](818da33))
* **lazygit:** enable boolean values in config
([#377](#377))
([ec34684](ec34684))
* **notifier:** open history window with correct style
([#307](#307))
([d2b5680](d2b5680))
* **notifier:** rename style `notification.history` ->
`notification_history`
([fd9ef30](fd9ef30))
* **scope:** allow treesitter scopes when treesitter highlighting is
disabled. See [#231](#231)
([58ae580](58ae580))
* **scope:** don't expand to invalid range. Fixes
[#339](#339)
([1244305](1244305))
* **scope:** properly caluclate start indent when `cursor=true` for
indent scopes. See
[#5068](https://github.com/folke/snacks.nvim/issues/5068)
([e63fa7b](e63fa7b))
* **scope:** use virtcol for calculating scopes at the cursor
([6a36f32](6a36f32))
* **scroll:** check for invalid window. Fixes
[#340](#340)
([b6032e8](b6032e8))
* **scroll:** don't animate when leaving cmdline search with incsearch
enabled. Fixes [#331](#331)
([fc0a99b](fc0a99b))
* **util:** throttle now autonatically schedules when in fast event
([9840331](9840331))
* **win:** backdrop having bright cell at top right
([#400](#400))
([373d0f9](373d0f9))
* **win:** don't enter when focusable is `false`
([ca233c7](ca233c7))
* **win:** force-close any buffer that is not a file
([dd50e53](dd50e53))
* **win:** unset `winblend` when transparent
([0617e28](0617e28))
* **words:** only check modes for `is_enabled` when needed
([80dcb88](80dcb88))
* **zen:** set zindex to 40, lower than hover (45). Closes
[#345](#345)
([05f4981](05f4981))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants