fix(gitbrowse): open commit not under cursor #393
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosheavni
changed the title
|
@folke any thoughts here? |
|
Wouldn't it be better to expose a field diff --git a/lua/snacks/gitbrowse.lua b/lua/snacks/gitbrowse.lua
index db71825..7f5459a 100644
--- a/lua/snacks/gitbrowse.lua
+++ b/lua/snacks/gitbrowse.lua
@@ -28,6 +28,7 @@ local defaults = {
---@type "repo" | "branch" | "file" | "commit"
what = "file", -- what to open. not all remotes support all types
branch = nil, ---@type string?
+ commit = nil, ---@type string?
line_start = nil, ---@type number?
line_end = nil, ---@type number?
-- patterns to transform remotes to an actual URL
@@ -142,7 +143,8 @@ function M._open(opts)
file = file and (uv.fs_stat(file) or {}).type == "file" and vim.fs.normalize(file) or nil
local cwd = file and vim.fn.fnamemodify(file, ":h") or vim.fn.getcwd()
local word = vim.fn.expand("<cword>")
- local is_commit = is_valid_commit_hash(word, cwd)
+ local commit_to_check = opts.commit or word
+ local is_commit = commit_to_check and is_valid_commit_hash(commit_to_check, cwd)
---@type snacks.gitbrowse.Fields
local fields = {
branch = opts.branch
@@ -150,7 +152,7 @@ function M._open(opts)
file = file and system({ "git", "-C", cwd, "ls-files", "--full-name", file }, "Failed to get git file path")[1],
line_start = opts.line_start,
line_end = opts.line_end,
- commit = is_commit and word or nil,
+ commit = is_commit and commit_to_check or nil,
}maybe? And user can then do PS: This is just a suggestion. Feel free to ignore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Open a commit if cword is not a commit and
whatis"commit"Related Issue(s)
#373