Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark namespace scope constexpr variable 'buffer_size' inline. #4084

Merged
merged 2 commits into from
Jul 24, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use provided macro for inline variable.
  • Loading branch information
kamrann committed Jul 23, 2024
commit 209dfb3c3a2563a75e7af947b1d9697c3424f7a8
2 changes: 1 addition & 1 deletion include/fmt/os.h
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ class file_buffer final : public buffer<char> {

} // namespace detail

inline constexpr auto buffer_size = detail::buffer_size();
FMT_INLINE_VARIABLE constexpr auto buffer_size = detail::buffer_size();

/// A fast output stream for writing from a single thread. Writing from
/// multiple threads without external synchronization may result in a data race.
Expand Down