Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented fmt::day, fmt::month, fmt::year and related unit tests #3906

Merged
merged 17 commits into from
Mar 28, 2024
Merged

Implemented fmt::day, fmt::month, fmt::year and related unit tests #3906

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
369296c
added custom formatters for std::chrono::day/month/year
zivshek Dec 21, 2023
79d801a
Implemented fmt::day, fmt::month, fmt::year
zivshek Mar 25, 2024
bd855f6
revert a test file that got committed accidentally
zivshek Mar 25, 2024
9688800
added custom formatters for std::chrono::day/month/year
zivshek Dec 21, 2023
5372701
Implemented fmt::day, fmt::month, fmt::year
zivshek Mar 25, 2024
ced6deb
revert a test file that got committed accidentally
zivshek Mar 25, 2024
0362061
merge with upstream
zivshek Mar 25, 2024
01c6aba
remove unnecessary using statements in chrono-test
zivshek Mar 25, 2024
18a7bf7
Fixed a compiler error in CPP20
zivshek Mar 25, 2024
32ff11e
take uint instead unsigned char for fmt::day and fmt::month as in std…
zivshek Mar 25, 2024
5c46fb1
fix weekday::c_encoding return value
zivshek Mar 25, 2024
9c9f697
fixed an issue that std uses a range of 1-12 for month, but fmt uses …
zivshek Mar 26, 2024
f0e1693
added custom formatters for std::chrono::day/month/year
zivshek Mar 25, 2024
42dee4a
Merge branch 'master' of https://github.com/zivshek/fmt
zivshek Mar 26, 2024
032edf1
address some feedback from code review
zivshek Mar 26, 2024
d7d5087
adding newline to the test file
zivshek Mar 26, 2024
e2e3f84
remove unnecessary include (that I added) in format.h
zivshek Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix weekday::c_encoding return value
  • Loading branch information
@zivshek
zivshek committed Mar 25, 2024
commit 5c46fb1e9f9cb2d511c2f185f9898ec390cd1631
2 changes: 1 addition & 1 deletion include/fmt/chrono.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2049,7 +2049,7 @@ class weekday {
weekday() = default;
explicit constexpr weekday(unsigned int wd) noexcept
zivshek marked this conversation as resolved.
Show resolved Hide resolved
: value(static_cast<unsigned char>(wd != 7 ? wd : 0)) {}
constexpr auto c_encoding() const noexcept -> unsigned char { return value; }
constexpr auto c_encoding() const noexcept -> unsigned int { return value; }
};

class day {
Expand Down