Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken integration tests #8299

Merged
merged 18 commits into from
Sep 6, 2024
Merged

Fix broken integration tests #8299

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
7d1a2f7
Test branch for bots
kenzieschmoll Sep 4, 2024
627285b
Enhance logging.
kenzieschmoll Sep 4, 2024
ae7920f
Undo initial commit
kenzieschmoll Sep 4, 2024
b9c49f3
try only running eval_and_inspect_test.dart
kenzieschmoll Sep 4, 2024
0cc3506
Add debug logging
kenzieschmoll Sep 4, 2024
ae7dd1e
add stdout/stderr prints
kenzieschmoll Sep 4, 2024
43cf9b4
logs
kenzieschmoll Sep 5, 2024
7a9bde6
log case
kenzieschmoll Sep 5, 2024
9e93501
remove extra logs
kenzieschmoll Sep 5, 2024
152fb11
Try to remove --headless
kenzieschmoll Sep 5, 2024
dfb8df1
cleanup
kenzieschmoll Sep 5, 2024
97af507
add browser dimension
kenzieschmoll Sep 5, 2024
0e329aa
Try disable GPU
kenzieschmoll Sep 5, 2024
68fba12
Try new chrome flags.
kenzieschmoll Sep 5, 2024
b4c335e
remove browser size and stale todo
kenzieschmoll Sep 5, 2024
483a177
only include extra flags for headless mode
kenzieschmoll Sep 6, 2024
802e448
simplify flags
kenzieschmoll Sep 6, 2024
fbf7746
changelog
kenzieschmoll Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Try disable GPU
  • Loading branch information
@kenzieschmoll
kenzieschmoll committed Sep 5, 2024
commit 0e329aa73b35fe9135e783cb1a64cb907aa1f8ca
4 changes: 3 additions & 1 deletion packages/devtools_shared/lib/src/test/integration_test_runner.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,10 @@ class IntegrationTestRunner with IOMixin {
'--target=$testTarget',
'-d',
headless ? 'web-server' : 'chrome',
// --disable-gpu speeds up tests that use ChromeDriver when run on
// GitHub Actions. See https://github.com/flutter/devtools/issues/8301.
'--web-browser-flag=--disable-gpu',
for (final arg in dartDefineArgs) '--dart-define=$arg',
'--browser-dimension=4000,4000',
];
debugLog('> flutter ${flutterDriveArgs.join(' ')}');
final process = await Process.start('flutter', flutterDriveArgs);
Expand Down
6 changes: 3 additions & 3 deletions tool/ci/bots.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,11 @@ completed). Download these goldens and update them in the codebase to apply the
# TODO(https://github.com/flutter/devtools/issues/8301): run these tests with the
# --headless flag once the issue with Chrome and chromedriver is resolved.
if [ "$DEVICE" = "flutter" ]; then
dart run integration_test/run_tests.dart --shard="$SHARD"
dart run integration_test/run_tests.dart --headless --shard="$SHARD"
elif [ "$DEVICE" = "flutter-web" ]; then
dart run integration_test/run_tests.dart --test-app-device=chrome --shard="$SHARD"
dart run integration_test/run_tests.dart --headless --test-app-device=chrome --shard="$SHARD"
elif [ "$DEVICE" = "dart-cli" ]; then
dart run integration_test/run_tests.dart --test-app-device=cli --shard="$SHARD"
dart run integration_test/run_tests.dart --headless --test-app-device=cli --shard="$SHARD"
fi
elif [ "$DEVTOOLS_PACKAGE" = "devtools_extensions" ]; then
pushd $DEVTOOLS_DIR/packages/devtools_extensions
Expand Down
Loading