custom: Destroy plugin instances on teardown instead of during property

checking Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
fluent · Apr 10, 2023 · 3a1b6db · 3a1b6db
1 parent 2c90848
commit 3a1b6db
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/flb_custom.c b/src/flb_custom.c
@@ -220,7 +220,6 @@ int flb_custom_plugin_property_check(struct flb_custom_instance *ins,
                 flb_helper("try the command: %s -F %s -h\n",
                            config->program_name, ins->p->name);
             }
-            flb_custom_instance_destroy(ins);
             return -1;
         }
     }
@@ -262,6 +261,7 @@ int flb_custom_init_all(struct flb_config *config)
          * configuration parameters are valid if the plugin is registering a config map.
          */
         if (flb_custom_plugin_property_check(ins, config) == -1) {
+            flb_custom_instance_destroy(ins);
             return -1;
         }