decode: fix leak #30
Merged
decode: fix leak #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=54137 Signed-off-by: David Korczynski <david@adalogics.com>
|
The CI error from the Markdown lint: is unrelated to this PR |
leonardo-albertovich
requested changes
Dec 21, 2022
src/ctr_decode_msgpack.c
Outdated
| @@ -117,6 +117,12 @@ static int unpack_instrumentation_scope_attributes(mpack_reader_t *reader, size_ | |||
| result = unpack_cfl_kvlist(reader, &attributes->kv); | |||
|
|
|||
| if (result != 0) { | |||
| if (attributes != NULL) { | |||
There was a problem hiding this comment.
You are right about the leak but please use ctr_attributes_destroy on attributes so if that object is modified in the future we're covered.
Additionally, would you mind adding a NULL check in line 112? It seems like I missed it and the result of ctr_attributes_create is not being checked which sucks (my bad!).
If you add the NULL check in line 112 you won't need to check if attributes is NULL here because unpack_cfl_kvlist only modifies the pointer held by the kv member.
Thanks a lot!
There was a problem hiding this comment.
Sounds good, done
leonardo-albertovich
approved these changes
Dec 21, 2022
Signed-off-by: David Korczynski <david@adalogics.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=54137
Signed-off-by: David Korczynski david@adalogics.com