Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robustify Git-Hooks for use with GitHub Desktop #499

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

EagleoutIce
Copy link
Member

I have no tried to robustify finding npm, following typicode/husky#912 (comment) and desktop/desktop#12562.

Could you (@Ehcsan) please try to check out this branch and push a dummy commit to see if it does now work?

@EagleoutIce EagleoutIce requested a review from Ehcsan November 20, 2023 21:52
@EagleoutIce EagleoutIce linked an issue Nov 20, 2023 that may be closed by this pull request
1 task
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a99a7f8) 70.64% compared to head (a2bc7eb) 70.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #499   +/-   ##
=======================================
  Coverage   70.64%   70.64%           
=======================================
  Files         212      212           
  Lines        6654     6654           
  Branches     1024     1024           
=======================================
  Hits         4701     4701           
  Misses       1688     1688           
  Partials      265      265           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EagleoutIce EagleoutIce changed the title Robustify Git-Hooks for use with GitHubDesktop Robustify Git-Hooks for use with GitHub Desktop Nov 20, 2023
@EagleoutIce EagleoutIce merged commit 5918e5d into main Nov 24, 2023
21 checks passed
@EagleoutIce EagleoutIce deleted the 485-bug-github-desktop-does-not-work branch November 24, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Github Desktop does not work
1 participant