Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I am using Svelte Simple Modal in Svelte 5 with some custom modifications. Would it be okay to submit a pull request? #117

Open
Neptunium1129 opened this issue Oct 28, 2024 · 6 comments

Comments

@Neptunium1129
Copy link

I think Svelte Simple Modal is very useful, more so than other open-source modal options.

previous project used only Simple Modal.

@Neptunium1129 Neptunium1129 changed the title I am using Svelte 5 with some self-modifications. Is it okay to submit a pull request? I am using Svelte Simple Modal in Svelte 5 with some custom modifications. Would it be okay to submit a pull request? Oct 28, 2024
@flekschas
Copy link
Owner

Totally! The only thing I hope we can achieve is backwards compatability with Svelte v4. If that's impossible we need to release a new major version of svelte-simple-modal.

@Neptunium1129
Copy link
Author

Totally! The only thing I hope we can achieve is backwards compatability with Svelte v4. If that's impossible we need to release a new major version of svelte-simple-modal.

It seems unlikely that backward compatibility will be possible due to the introduction of Svelte 5

@flekschas
Copy link
Owner

flekschas commented Oct 29, 2024

Do you know what technically prevents that? When Svelte v4 was released, svelte-simple-modal continued to work just fine with Svelte v3.

@nltesown
Copy link

nltesown commented Nov 7, 2024

@Neptunium1129 I've taken a look at your fork https://github.com/Neptunium1129/svelte-simple-modal but I don't see any edit... svelte-simple-modal is a fantastic package and it definitely should be made compatible with Svelte 5. I wondered where would the incompatibility come from.

@flekschas
Copy link
Owner

@nltesown You could check #113 and #114. I'm happy to get a PR in for v5 support, I just don't have time to look into it myself right now. In the linked tickets, there was a backward-incompatible change I believe. If there's no way around it we can simply bump svelte simply modal to v2. That's totally fine

@Neptunium1129
Copy link
Author

@Neptunium1129 I've taken a look at your fork https://github.com/Neptunium1129/svelte-simple-modal but I don't see any edit... svelte-simple-modal is a fantastic package and it definitely should be made compatible with Svelte 5. I wondered where would the incompatibility come from.

I have confirmed it works in my local environment and will update it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants