-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I am using Svelte Simple Modal in Svelte 5 with some custom modifications. Would it be okay to submit a pull request? #117
Comments
Totally! The only thing I hope we can achieve is backwards compatability with Svelte v4. If that's impossible we need to release a new major version of svelte-simple-modal. |
It seems unlikely that backward compatibility will be possible due to the introduction of Svelte 5 |
Do you know what technically prevents that? When Svelte v4 was released, svelte-simple-modal continued to work just fine with Svelte v3. |
@Neptunium1129 I've taken a look at your fork https://github.com/Neptunium1129/svelte-simple-modal but I don't see any edit... svelte-simple-modal is a fantastic package and it definitely should be made compatible with Svelte 5. I wondered where would the incompatibility come from. |
@nltesown You could check #113 and #114. I'm happy to get a PR in for v5 support, I just don't have time to look into it myself right now. In the linked tickets, there was a backward-incompatible change I believe. If there's no way around it we can simply bump svelte simply modal to v2. That's totally fine |
I have confirmed it works in my local environment and will update it soon. |
I think Svelte Simple Modal is very useful, more so than other open-source modal options.
previous project used only Simple Modal.
The text was updated successfully, but these errors were encountered: