Ok, yes I see the issue is that the test_media_types_q test case (which predates these changes) tests an invalid Accept header: 'Accept': 'application/json; q=1; application/xml; q=.5'

This is not a valid HTTP Accept header according to rfc2616 because the two media-range [ accept-params ] entries need to be delimited by commas, not semicolons.

The ABNF for Accept (rfc2616 section 14.1) is:

Accept         = "Accept" ":"
                        #( media-range [ accept-params ] )

       media-range    = ( "*/*"
                        | ( type "/" "*" )
                        | ( type "/" subtype )
                        ) *( ";" parameter )
       accept-params  = ";" "q" "=" qvalue *( accept-extension )
       accept-extension = ";" token [ "=" ( token | quoted-string ) ]

Note that the #() syntax in ABNF means to separate the list entries by commas with optional whitespace.

Applying the following patch should fix it.

--- a/tests/test_api.py
+++ b/tests/test_api.py
@@ -519,7 +519,7 @@ class APITestCase(unittest.TestCase):
         api = flask_restful.Api(app)

         with app.test_request_context("/foo", headers={
-            'Accept': 'application/json; q=1; application/xml; q=.5'
+            'Accept': 'application/json; q=1, application/xml; q=.5'
         }):
             self.assertEquals(api.mediatypes(),
                               ['application/json', 'application/xml'])

Previous versions of Werkzeug were somewhat more lax in their parsing of accept headers, but while fixing up the handling of q= parameters I had to make it parse them more strictly.

Unskip tests added in #245 #392

Description

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions