Skip to content

[optimistic] Per-instance waitgroup inaccurately reflects status of optimistic processing #534

Open
@michaelneuder

Description

Describe the bug
As pointed out by Auston and Max of aestus relay, the current waitgroup design for handling optimistic block processing only works on a per-instance basis. In order to work as intended, some cross-process synchronization step is needed. Probably the best way to do this is through redis.

Expected behavior
The waitgroup is incremented up receipt of each optimistic builder submission:

api.optimisticBlocksWG.Add(1)

It is then waited on in a few places to try to ensure there is no outstanding optimistic blocks being processed:

api.optimisticBlocksWG.Wait()

Since there are multiple builder API and proposer API instances, the per-instance waitgroup isn't sufficient to ensure that all the optimistic blocks have been processed.

Additional context
Auston has explored changes to redis to handle this coordination: austonst@f52c977

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions