chore: remove compat API

Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
flarum · imorland · Jun 29, 2023 · Jun 14, 2023 · Jun 21, 2023 · Jun 22, 2023
commit 09007014fe9ba48d1007941b6ee56c6a13a5f6d3
@@ -15,7 +15,7 @@
     "declarationDir": "./dist-typings",
     "paths": {
       "flarum/*": ["../../../framework/core/js/dist-typings/*"],
-      "flarum/flags/*": ["../../flags/js/dist-typings/*"]
+      "ext:flarum/flags/*": ["../../flags/js/dist-typings/*"]
     }
   }
 }
@@ -1,5 +1,5 @@
 import app from 'flarum/forum/app';
-import Page from 'flarum/components/Page';
+import Page from 'flarum/common/components/Page';
 
 import FlagList from './FlagList';
 

@@ -0,0 +1,10 @@
+import './addFlagsToPosts';
+import './addFlagControl';
+import './addFlagsDropdown';
+
+import './models/Flag';
+
+import './components/FlagList';
+import './components/FlagPostModal';
+import './components/FlagsPage';
+import './components/FlagsDropdown';
@@ -15,8 +15,4 @@ app.initializers.add('flarum-flags', () => {
   addFlagsToPosts();
 });
 
-// Expose compat API
-import flagsCompat from './compat';
-import { compat } from '@flarum/core/forum';
-
-Object.assign(compat, flagsCompat);
+import './forum';
@@ -0,0 +1,14 @@
+import './components/GroupMentionedNotification';
+import './components/MentionsUserPage';
+import './components/PostMentionedNotification';
+import './components/UserMentionedNotification';
+import './fragments/AutocompleteDropdown';
+import './fragments/PostQuoteButton';
+import './utils/getCleanDisplayName';
+import './utils/getMentionText';
+import './utils/reply';
+import './utils/selectedText';
+import './utils/textFormatter';
+import './mentionables/MentionableModel';
+import './mentionables/formats/MentionFormat';
+import './extenders/Mentionables';
@@ -15,8 +15,6 @@ import UserMentionedNotification from './components/UserMentionedNotification';
 import GroupMentionedNotification from './components/GroupMentionedNotification';
 import UserPage from 'flarum/forum/components/UserPage';
 import LinkButton from 'flarum/common/components/LinkButton';
-import User from 'flarum/common/models/User';
-import Model from 'flarum/common/Model';
 
 export { default as extend } from './extend';
 
@@ -90,8 +88,4 @@ app.initializers.add('flarum-mentions', function () {
 
 export * from './utils/textFormatter';
 
-// Expose compat API
-import mentionsCompat from './compat';
-import { compat } from '@flarum/core/forum';
-
-Object.assign(compat, mentionsCompat);
+import './forum';
@@ -1,7 +1,7 @@
 import app from 'flarum/forum/app';
 import Badge from 'flarum/common/components/Badge';
 import highlight from 'flarum/common/helpers/highlight';
-import type Tag from 'flarum/tags/common/models/Tag';
+import type Tag from 'ext:flarum/tags/common/models/Tag';
 import type Mithril from 'mithril';
 import MentionableModel from './MentionableModel';
 import type HashMentionFormat from './formats/HashMentionFormat';

@@ -10,7 +10,7 @@
     "declarationDir": "./dist-typings",
     "paths": {
       "flarum/*": ["../../../framework/core/js/dist-typings/*"],
-      "flarum/tags/*": ["../../tags/js/dist-typings/*"],
+      "ext:flarum/tags/*": ["../../tags/js/dist-typings/*"],
       // TODO: remove after export registry system implemented
       // Without this, the old-style `@flarum/core` import is resolved to
       // source code in flarum/core instead of the dist typings.

@@ -7,7 +7,7 @@ import IndexPage from 'flarum/forum/components/IndexPage';
 import Button from 'flarum/common/components/Button';
 import ItemList from 'flarum/common/utils/ItemList';
 import type { Children } from 'mithril';
-import type Tag from 'flarum/tags/common/models/Tag';
+import type Tag from 'ext:flarum/tags/common/models/Tag';
 
 export type PusherBinding = {
   channels: {

@@ -10,7 +10,7 @@
     "declarationDir": "./dist-typings",
     "paths": {
       "flarum/*": ["../../../framework/core/js/dist-typings/*"],
-      "flarum/tags/*": ["../../tags/js/dist-typings/*"]
+      "ext:flarum/tags/*": ["../../tags/js/dist-typings/*"]
     }
   }
 }
@@ -1,4 +1,4 @@
-import app from 'flarum/app';
+import app from 'flarum/admin/app';
 
 app.initializers.add('flarum-suspend', () => {
   app.extensionData.for('flarum-suspend').registerPermission(

@@ -1,10 +1,10 @@
 import app from 'flarum/forum/app';
-import Modal from 'flarum/components/Modal';
-import Button from 'flarum/components/Button';
-
-import Stream from 'flarum/utils/Stream';
-import withAttr from 'flarum/utils/withAttr';
+import Modal from 'flarum/common/components/Modal';
+import Button from 'flarum/common/components/Button';
+import Stream from 'flarum/common/utils/Stream';
+import withAttr from 'flarum/common/utils/withAttr';
 import ItemList from 'flarum/common/utils/ItemList';
+
 import { getPermanentSuspensionDate } from '../helpers/suspensionHelper';
 
 export default class SuspendUserModal extends Modal {

@@ -1,5 +1,6 @@
 import app from 'flarum/forum/app';
-import Notification from 'flarum/components/Notification';
+import Notification from 'flarum/forum/components/Notification';
+
 import { isPermanentSuspensionDate } from '../helpers/suspensionHelper';
 
 export default class UserSuspendedNotification extends Notification {

@@ -1,5 +1,5 @@
 import app from 'flarum/forum/app';
-import Notification from 'flarum/components/Notification';
+import Notification from 'flarum/forum/components/Notification';
 
 export default class UserUnsuspendedNotification extends Notification {
   icon() {

@@ -0,0 +1,6 @@
+import './components/SuspendUserModal';
+import './components/SuspensionInfoModal';
+import './components/UserSuspendedNotification';
+import './components/UserUnsuspendedNotification';
+
+import './checkForSuspension';
@@ -1,9 +1,9 @@
-import { extend } from 'flarum/extend';
-import app from 'flarum/app';
-import UserControls from 'flarum/utils/UserControls';
-import Button from 'flarum/components/Button';
-import Badge from 'flarum/components/Badge';
-import User from 'flarum/models/User';
+import { extend } from 'flarum/common/extend';
+import app from 'flarum/forum/app';
+import UserControls from 'flarum/forum/utils/UserControls';
+import Button from 'flarum/common/components/Button';
+import Badge from 'flarum/common/components/Badge';
+import User from 'flarum/common/models/User';
 
 import SuspendUserModal from './components/SuspendUserModal';
 import UserSuspendedNotification from './components/UserSuspendedNotification';
@@ -42,8 +42,4 @@ app.initializers.add('flarum-suspend', () => {
   checkForSuspension();
 });
 
-// Expose compat API
-import suspendCompat from './compat';
-import { compat } from '@flarum/core/forum';
-
-Object.assign(compat, suspendCompat);
+import './forum';
@@ -0,0 +1,9 @@
+import '../common/common';
+
+import './components/TagsPage';
+import './components/EditTagModal';
+
+import './addTagsHomePageOption';
+import './addTagChangePermission';
+import './addTagPermission';
+import './addTagsPermissionScope';
@@ -21,8 +21,4 @@ app.initializers.add('flarum-tags', (app) => {
   addTagSelectionSettingComponent();
 });
 
-// Expose compat API
-import tagsCompat from './compat';
-import { compat } from '@flarum/core/admin';
-
-Object.assign(compat, tagsCompat);
+import './admin';
@@ -0,0 +1,11 @@
+import './utils/sortTags';
+
+import './models/Tag';
+
+import './helpers/tagsLabel';
+import './helpers/tagIcon';
+import './helpers/tagLabel';
+
+import './components/TagSelectionModal';
+
+import './states/TagListState';
@@ -0,0 +1,15 @@
+import '../common/common';
+
+import './utils/getSelectableTags';
+
+import './components/TagHero';
+import './components/TagDiscussionModal';
+import './components/TagsPage';
+import './components/DiscussionTaggedPost';
+import './components/TagLinkButton';
+
+import './addTagFilter';
+import './addTagControl';
+import './addTagList';
+import './addTagLabels';
+import './addTagComposer';
@@ -20,8 +20,4 @@ app.initializers.add('flarum-tags', function () {
   addTagComposer();
 });
 
-// Expose compat API
-import tagsCompat from './compat';
-import { compat } from '@flarum/core/forum';
-
-Object.assign(compat, tagsCompat);
+import './forum';