Skip to content

TODO: try not to use vite's createIdResolver #17

Closed
@dario-piotrowicz

Description

Currently we're using createIdResolver from vite to create module resolvers that we use in the module fallback service callback.

We should explore if we could instead use a separate third party solution (like import-meta-resolve, enhanced-resolve, resolve, etc...).


Why would that be beneficial?

  • The vite team exposed the createIdResolver utility especially for us, but this is not a utility that they would like to have to expose and maintain (discussion)
  • We could reuse our module resolution implementation in vitest-pool-workers whilst it still needs to use vite@5 (PS: this would be pretty valuable in the short/middle term, not at all in the long term as vitest-pool-workers should ideally just reuse our vite environment solution under the hood)
  • Our module fallback solution could become fairly generic, we could even externalize it in its own package and it could be used in non-vite projects (although I am not sure if/what use cases for this there are)

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions