[mlir rebase] Add MLIR config and react to MLIR name changes #1090
Conversation
Similar to #1085. Now use the MLIR package to set up paths for include files and libraries. Three MLIR names changed: * VectorOpsDialect to VectorDialect * AffineOpsDialect to AffineDialect * createVectorizePass to createSuperVectorizePass
There was a problem hiding this comment.
Thanks for updating #1085, build fine against LLVM head from this morning for me.
|
This doesn't build for me. I'm getting this: I'm using the latest on the f18 branch from flang-compiler/f18-llvm-project. There is no Can you update the build instructions? |
Jean is updating f18-llvm-project. |
MLIR. Update the example gcc to version 8.3.
I have actually updated it a few hours ago already, can you check with |
| LLVM=<LLVM_BUILD_DIR>/lib/cmake/llvm cmake -DLLVM_DIR=$LLVM ... | ||
| LLVM=<LLVM_BUILD_DIR>/lib/cmake/llvm \ | ||
| MLIR=<LLVM_BUILD_DIR>/lib/cmake/mlir \ | ||
| cmake -DLLVM_DIR=$LLVM -DMLIR_DIR=$MLIR ... |
There was a problem hiding this comment.
Above 3 lines can be replaced by,
cmake -DCMAKE_PREFIX_PATH=<LLVM_BUILD_DIR>
There was a problem hiding this comment.
Good catch @isuruf. I'll update the instructions in a subsequent PR, along with .drone.io files. The reason for delay is because I'd like to check this method in my own build farm.
There was a problem hiding this comment.
Sure. See https://cmake.org/cmake/help/latest/command/find_package.html#search-procedure for more info on why it works. You can also use cmake --debug-find with 3.17.0 and cmake will tell you which paths that it tried.
…lang-compiler/f18#1090) [mlir rebase] Add MLIR config and react to MLIR name changes Similar to flang-compiler/f18#1085. Now use the MLIR package to set up paths for include files and libraries. Three MLIR names changed: * VectorOpsDialect to VectorDialect * AffineOpsDialect to AffineDialect * createVectorizePass to createSuperVectorizePass Update README.md to explain how to link with MLIR. Update the example gcc to version 8.3. Update drone.io config to define -DMLIR_DIR Co-authored-by: Jean Perier <jperier@nvidia.com> Original-commit: flang-compiler/f18@116f643 Reviewed-on: flang-compiler/f18#1090
…lang-compiler/f18#1090) [mlir rebase] Add MLIR config and react to MLIR name changes Similar to flang-compiler/f18#1085. Now use the MLIR package to set up paths for include files and libraries. Three MLIR names changed: * VectorOpsDialect to VectorDialect * AffineOpsDialect to AffineDialect * createVectorizePass to createSuperVectorizePass Update README.md to explain how to link with MLIR. Update the example gcc to version 8.3. Update drone.io config to define -DMLIR_DIR Co-authored-by: Jean Perier <jperier@nvidia.com> Original-commit: flang-compiler/f18@116f643 Reviewed-on: flang-compiler/f18#1090
Similar to #1085. Now use the MLIR package to set up paths
for include files and libraries. Three MLIR names changed:
Also, resolves the merge conflict in #1085.
Note, when building out of tree, supply MLIR_DIR to cmake: