Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MainichiShimbun #685

Merged
merged 6 commits into from
Jan 23, 2025
Merged

Add MainichiShimbun #685

merged 6 commits into from
Jan 23, 2025

Conversation

MaxDall
Copy link
Collaborator

@MaxDall MaxDall commented Jan 14, 2025

No description provided.

@MaxDall MaxDall requested a review from addie9800 January 14, 2025 13:57
@MaxDall MaxDall changed the base branch from master to add-tokyo-shimbun January 14, 2025 13:57
addie9800
addie9800 requested changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@addie9800 addie9800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding 👍

src/fundus/publishers/jp/mainichi_shimbun.py Outdated Show resolved Hide resolved
src/fundus/publishers/jp/mainichi_shimbun.py Outdated Show resolved Hide resolved
Base automatically changed from add-tokyo-shimbun to master January 16, 2025 11:36
@MaxDall MaxDall requested a review from addie9800 January 20, 2025 15:23
addie9800
addie9800 approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@addie9800 addie9800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. While reviewing I stumbled across an article with a subheadline and went ahead and added a corresponding selector.

@MaxDall
Copy link
Collaborator Author

MaxDall commented Jan 23, 2025

Looks good. While reviewing I stumbled across an article with a subheadline and went ahead and added a corresponding selector.

Perfect. Thank you!

@MaxDall MaxDall merged commit 84d9215 into master Jan 23, 2025
5 checks passed
@MaxDall MaxDall deleted the add-mainichi-shimbun branch January 23, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addie9800 addie9800 addie9800 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxDall @addie9800