Use constant for arrays that don't change

fivefilters · Dec 7, 2024 · 2d3345c · 2d3345c
1 parent 71ab250
commit 2d3345c
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/Nodes/NodeTrait.php b/src/Nodes/NodeTrait.php
@@ -31,7 +31,7 @@ trait NodeTrait
      */
     private bool $readabilityDataTable = false;
 
-    private array $divToPElements = [
+    private const DIV_TO_P_ELEMENTS = [
         'blockquote',
         'dl',
         'div',
@@ -47,7 +47,7 @@ trait NodeTrait
      * The commented out elements qualify as phrasing content but tend to be
      * removed by readability when put into paragraphs, so we ignore them here.
      */
-    private array $phrasing_elems = [
+    private const PHRASING_ELEMS = [
         // 'CANVAS', 'IFRAME', 'SVG', 'VIDEO',
         'abbr', 'audio', 'b', 'bdo', 'br', 'button', 'cite', 'code', 'data',
         'datalist', 'dfn', 'em', 'embed', 'i', 'img', 'input', 'kbd', 'label',
@@ -367,14 +367,14 @@ public function hasSingleTagInsideElement(string $tag): bool
 
     /**
      * Check if the current element has a single child block element.
-     * Block elements are the ones defined in the divToPElements array.
+     * Block elements are the ones defined in the DIV_TO_P_ELEMENTS array.
      */
     public function hasSingleChildBlockElement(): bool
     {
         $result = false;
         if ($this->hasChildNodes()) {
             foreach ($this->childNodes as $child) {
-                if (in_array($child->nodeName, $this->divToPElements)) {
+                if (in_array($child->nodeName, self::DIV_TO_P_ELEMENTS)) {
                     $result = true;
                 } else {
                     // If any of the hasSingleChildBlockElement calls return true, return true then.
@@ -417,7 +417,7 @@ public function isElementWithoutContent(): bool
      */
     public function isPhrasingContent(): bool
     {
-        return $this->nodeType === XML_TEXT_NODE || in_array($this->nodeName, $this->phrasing_elems) !== false ||
+        return $this->nodeType === XML_TEXT_NODE || in_array($this->nodeName, self::PHRASING_ELEMS) !== false ||
             (!is_null($this->childNodes) &&
                 ($this->nodeName === 'a' || $this->nodeName === 'del' || $this->nodeName === 'ins') &&
                 array_reduce(iterator_to_array($this->childNodes), function ($carry, $node) {