Block TTY control signals in processes started from subshells #6893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same for processes started from event handlers. This is consistent with the bash equivalent: from https://www.gnu.org/software/bash/manual/html_node/Signals.html Commands run as a result of command substitution ignore the keyboard-generated job control signals SIGTTIN, SIGTTOU, and SIGTSTP. Fixes fish-shell#6300 (caused by SIGTTOU from subshell) Fixes fish-shell#6624 (caused by SIGTTIN from subshell) Probably also fish-shell#6692 which shows very similar symptoms to fish-shell#6624, but I have't been able to reproduce that.
krobelus
force-pushed
the
block-tty-signals
branch
from
c730894 to
334a125
Compare
|
Ugh, this doesn't actually fix #6300, but now it always reproduces. I'll take another look. |
|
See also #1362, where fish handled the issue in a different way to bash |
|
OK this does definitely not work since the issue is not specific to subshells, see the example in #6624 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same for processes started from event handlers.
This is consistent with the bash equivalent: from
https://www.gnu.org/software/bash/manual/html_node/Signals.html
Fixes #6300 (caused by SIGTTOU from subshell)
Fixes #6624 (caused by SIGTTIN from subshell)
Probably also #6692 which shows very similar symptoms to #6624, but I
have't been able to reproduce that.
TODOs: