Files that changed from the base of the PR and between cf19353 and 0af162e.

• qa/rpc-tests/llmq-is-spark.py (1 hunks)
• qa/rpc-tests/spark_mint.py (1 hunks)
• qa/rpc-tests/spark_setmintstatus_validation.py (2 hunks)
• qa/rpc-tests/spark_spend_gettransaction.py (1 hunks)
• src/qt/sendcoinsdialog.cpp (4 hunks)
• src/qt/sparkmodel.cpp (2 hunks)
• src/qt/walletmodel.cpp (3 hunks)
• src/qt/walletmodeltransaction.cpp (2 hunks)
• src/spark/sparkwallet.cpp (9 hunks)
• src/spark/sparkwallet.h (1 hunks)
• src/test/evospork_tests.cpp (1 hunks)
• src/test/fixtures.cpp (2 hunks)
• src/wallet/rpcwallet.cpp (3 hunks)
• src/wallet/test/spark_tests.cpp (9 hunks)
• src/wallet/wallet.cpp (7 hunks)
• src/wallet/wallet.h (2 hunks)

• qa/rpc-tests/spark_setmintstatus_validation.py (no review received)
• src/qt/walletmodeltransaction.cpp (no review received)
• qa/rpc-tests/spark_spend_gettransaction.py (no review received)
• qa/rpc-tests/llmq-is-spark.py (no review received)
• src/qt/sparkmodel.cpp (no review received)
• qa/rpc-tests/spark_mint.py (no review received)

src/spark/sparkwallet.h (1)

117-117: The addition of vecSend parameter in CreateSparkMintTransactions method aligns with the PR's multi-send feature.

src/test/fixtures.cpp (1)

Line range hint 362-373: The initialization of vecSend and its use in MintAndStoreSpark correctly reflects the changes made in CSparkWallet. This ensures that the test setup aligns with the new functionality.

src/wallet/test/spark_tests.cpp (1)

79-80: The introduction of vecSend in various test cases correctly reflects the updated method signature in MintAndStoreSpark. The tests are well-structured to check the new functionality.

Also applies to: 185-186, 335-336, 426-427, 477-477

src/qt/sendcoinsdialog.cpp (4)

533-533: Confirm the handling of Spark transactions in non-anonymous mode.

Verification successful

Let's proceed by examining the implementation of the mintSparkCoins method in walletmodel.cpp to ensure it handles Spark transactions correctly.

---

Let's try a different approach to locate and review the implementation of the mintSparkCoins method in walletmodel.cpp.

---

The implementation of the mintSparkCoins method in walletmodel.cpp has been successfully retrieved. The method appears to handle Spark transactions by committing transactions and processing recipients' messages.

• The method locks the wallet and main chain.
• It iterates over the transactions and commits each one.
• It handles messages from recipients and serializes the transaction.

This confirms that the mintSparkCoins method is designed to handle Spark transactions properly when fAnonymousMode is false, sparkAddressCount is greater than 0, and spark::IsSparkAllowed() returns true.

Scripts executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify that Spark transactions are handled correctly when `fAnonymousMode` is false and `sparkAddressCount` is greater than 0.

# Test: Search for the method usage. Expect: Proper transaction handling.
rg --type cpp $'mintSparkCoins'

Length of output: 421

---

---

Script:

#!/bin/bash
# Description: Retrieve the implementation of the mintSparkCoins method in walletmodel.cpp to verify proper handling of Spark transactions.

# Extract the implementation of mintSparkCoins from walletmodel.cpp
ast-grep --lang cpp --pattern $'WalletModel::SendCoinsReturn WalletModel::mintSparkCoins($_, $_, $_) {
  $$$
}' 

Length of output: 112

---

---

Script:

#!/bin/bash
# Description: Retrieve the implementation of the mintSparkCoins method in walletmodel.cpp to verify proper handling of Spark transactions.

# Extract the implementation of mintSparkCoins from walletmodel.cpp using ripgrep to locate the function definition.
rg --type cpp --context 20 'WalletModel::SendCoinsReturn WalletModel::mintSparkCoins'

Length of output: 2834

---

491-491: Check the total amount calculation logic for various transaction scenarios.

Verification successful

---

The getTotalTransactionAmount method in walletmodeltransaction.cpp sums up the amounts from the recipients list. This logic appears straightforward and correct for calculating the total transaction amount.

The usage of this method in sendcoinsdialog.cpp and lelantusdialog.cpp also seems consistent with its purpose.

• sendcoinsdialog.cpp:

  • mintSparkAmount += transaction.getTotalTransactionAmount();
  • totalAmount = currentTransaction.getTotalTransactionAmount() + txFee;

• lelantusdialog.cpp:

  • allAmount += wtx.getTotalTransactionAmount();

These usages indicate that the total transaction amount is being correctly calculated and used in different contexts.

Scripts executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify that the total amount is calculated correctly for different transaction scenarios, especially when `fAnonymousMode` is toggled.

# Test: Search for the method usage. Expect: Correct total amount calculations.
rg --type cpp $'getTotalTransactionAmount'

Length of output: 492

---

---

Script:

#!/bin/bash
# Retrieve the implementation of getTotalTransactionAmount in walletmodeltransaction.cpp
ast-grep --lang cpp --pattern $'CAmount WalletModelTransaction::getTotalTransactionAmount() {
  $$$
}' --json

# Retrieve the usage of getTotalTransactionAmount in sendcoinsdialog.cpp
rg --type cpp 'getTotalTransactionAmount' src/qt/sendcoinsdialog.cpp

# Retrieve the usage of getTotalTransactionAmount in lelantusdialog.cpp
rg --type cpp 'getTotalTransactionAmount' src/qt/lelantusdialog.cpp

Length of output: 454

---

---

Script:

#!/bin/bash
# Retrieve the implementation of getTotalTransactionAmount in walletmodeltransaction.cpp
rg --type cpp 'CAmount WalletModelTransaction::getTotalTransactionAmount' src/qt/walletmodeltransaction.cpp

Length of output: 169

---

---

Script:

#!/bin/bash
# Retrieve the full implementation of getTotalTransactionAmount in walletmodeltransaction.cpp
rg --type cpp -A 10 -B 10 'CAmount WalletModelTransaction::getTotalTransactionAmount' src/qt/walletmodeltransaction.cpp

Length of output: 588

---

465-465: Validate the calculation of transaction fees and sizes for Spark transactions.

---

335-335: Ensure correct handling of Spark transactions when fAnonymousMode is false.

Verification successful

---

Ensure correct handling of Spark transactions when fAnonymousMode is false.

The prepareMintSparkTransaction method in src/qt/walletmodel.cpp correctly handles Spark transactions, including checks for valid addresses, amounts, and balance. The method prepares the transaction data and ensures that the transaction is created successfully, emitting error messages if any issues arise.

• src/qt/walletmodel.cpp: Implementation of prepareMintSparkTransaction method.

Scripts executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify that the `prepareMintSparkTransaction` method correctly handles transactions when `fAnonymousMode` is false and `sparkAddressCount` is greater than 0.

# Test: Search for the method usage. Expect: Proper handling of transactions.
rg --type cpp $'prepareMintSparkTransaction'

Length of output: 571

---

---

Script:

#!/bin/bash
# Extract the implementation of the `prepareMintSparkTransaction` method from `src/qt/walletmodel.cpp`.
ast-grep --lang cpp --pattern $'SendCoinsReturn WalletModel::prepareMintSparkTransaction($_, $_, $_, $_, $_) {
  $$$
}' src/qt/walletmodel.cpp

Length of output: 143

---

---

Script:

#!/bin/bash
# Extract the implementation of the `prepareMintSparkTransaction` method from `src/qt/walletmodel.cpp` with a more flexible pattern.
ast-grep --lang cpp --pattern $'SendCoinsReturn WalletModel::prepareMintSparkTransaction($_, $_, $_, $_, $_) {
  $$$
}' src/qt/walletmodel.cpp

Length of output: 143

---

---

Script:

#!/bin/bash
# Search for the definition of `prepareMintSparkTransaction` in `src/qt/walletmodel.cpp` and extract the surrounding lines to get the full implementation.
rg --context 20 'SendCoinsReturn WalletModel::prepareMintSparkTransaction' src/qt/walletmodel.cpp

Length of output: 1482

---

---

Script:

#!/bin/bash
# Search for the definition of `prepareMintSparkTransaction` in `src/qt/walletmodel.cpp` and extract more surrounding lines to get the full implementation.
rg --context 50 'SendCoinsReturn WalletModel::prepareMintSparkTransaction' src/qt/walletmodel.cpp

Length of output: 3279

---

---

Script:

#!/bin/bash
# Search for the definition of `prepareMintSparkTransaction` in `src/qt/walletmodel.cpp` and extract even more surrounding lines to get the full implementation.
rg --context 100 'SendCoinsReturn WalletModel::prepareMintSparkTransaction' src/qt/walletmodel.cpp

Length of output: 7304

src/wallet/wallet.h (2)

1041-1041: Ensure the new method signature is consistent with its implementation and usage across the project.

Verification successful

---

The method signature for CreateSparkMintTransactions is consistent across the project. The header file, source file implementations, and usages all align with the new signature.

• Header File: src/wallet/wallet.h
• Source File Implementations: src/wallet/wallet.cpp, src/spark/sparkwallet.cpp
• Usages: src/wallet/wallet.cpp, src/qt/walletmodel.cpp

Scripts executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify that the new method signature for `CreateSparkMintTransactions` is used consistently across the project.

# Test: Search for the method usage. Expect: Only occurrences of the new signature.
ast-grep --lang cpp --pattern $'class CWallet {
  $$$
  CreateSparkMintTransactions($_, $_, $_, $_, $_, $_, $_, $_, $_, $_) {
    $$$
  }
  $$$  
}'

Length of output: 494

---

---

Script:

#!/bin/bash
# Description: Verify the method signature for `CreateSparkMintTransactions` in the header file and its implementation and usage across the project.

# Step 1: Search for the method signature in the header file.
echo "Searching for method signature in header files..."
ast-grep --lang cpp --pattern 'CreateSparkMintTransactions(const std::vector<CRecipient>&, $_, $_, $_, $_, $_, $_, $_, $_)' > header_signature.txt

# Step 2: Search for the method implementation in the source files.
echo "Searching for method implementation in source files..."
ast-grep --lang cpp --pattern 'CreateSparkMintTransactions(const std::vector<CRecipient>&, $_, $_, $_, $_, $_, $_, $_, $_) {' > source_implementation.txt

# Step 3: Search for the method usage across the project.
echo "Searching for method usage across the project..."
rg 'CreateSparkMintTransactions\(' > method_usage.txt

# Combine results for review.
echo "Combining results..."
cat header_signature.txt source_implementation.txt method_usage.txt

Length of output: 1634

---

1092-1092: Ensure the new method signature is consistent with its implementation and usage across the project.

src/spark/sparkwallet.cpp (2)

753-753: Ensure proper error handling for CreateSparkMintTransactions.

---

1267-1270: Verify logic for handling remaining transaction value.

src/wallet/rpcwallet.cpp (2)

3642-3658: Ensure the help text and examples are clear and accurate.

Verification successful

---

The help text and examples for the mintspark command in src/wallet/rpcwallet.cpp appear to be accurate and consistent with the function's implementation. The function definition and the help text both describe the command's usage, parameters, and expected results clearly.

• The help text specifies the format for the mintspark command, including the address, amount, memo, and subtractfee parameters.
• The examples provided in the help text demonstrate typical use cases for the mintspark command, including sending amounts to transparent and private addresses.

Based on the extracted implementation and the provided help text, no discrepancies were found.

Scripts executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify the accuracy of the help text and examples for the `mintspark` command.

# Test: Search for the `mintspark` command usage in the documentation and compare with the help text.
rg --type markdown $'mintspark'

Length of output: 30

---

---

Script:

#!/bin/bash
# Description: Locate the implementation of the `mintspark` command in the codebase and review its parameters and usage.

# Search for the `mintspark` command implementation in the codebase.
ast-grep --lang cpp --pattern $'void mintspark($_) {
  $$$
}'

Length of output: 62

---

---

Script:

#!/bin/bash
# Description: Search for the `mintspark` keyword in the codebase to locate its definition and usage.

# Search for the `mintspark` keyword in the codebase.
rg 'mintspark'

Length of output: 4136

---

---

Script:

#!/bin/bash
# Description: Extract the implementation of the `mintspark` function from `src/wallet/rpcwallet.cpp`.

# Extract the implementation of the `mintspark` function.
ast-grep --lang cpp --pattern $'UniValue mintspark(const JSONRPCRequest& request) {
  $$$
}' src/wallet/rpcwallet.cpp

Length of output: 118

---

---

Script:

#!/bin/bash
# Description: Search for the `mintspark` function definition in `src/wallet/rpcwallet.cpp`.

# Search for the `mintspark` function definition.
rg 'UniValue mintspark' src/wallet/rpcwallet.cpp

Length of output: 100

---

---

Script:

#!/bin/bash
# Description: Extract the full implementation of the `mintspark` function from `src/wallet/rpcwallet.cpp`.

# Extract the full implementation of the `mintspark` function.
rg -A 50 'UniValue mintspark' src/wallet/rpcwallet.cpp

Length of output: 4071

---

3675-3755: Review the logic for handling Spark and Bitcoin addresses, validating parameters, and preparing data for transaction creation.

Verification successful

---

The verification process has confirmed the presence and implementation of the functions and classes involved in the logic for handling Spark and Bitcoin addresses, validating parameters, and preparing data for transaction creation. The following points summarize the findings:

• The decode method for Spark addresses is implemented in src/libspark/keys.cpp.
• The CBitcoinAddress class and its IsValid method are implemented in src/base58.cpp.
• The AmountFromValue function is implemented in src/rpc/server.cpp.
• The MintAndStoreSpark method is implemented in src/wallet/wallet.cpp.

These implementations confirm that the logic in the provided code snippet is supported by the necessary functions and classes.

Scripts executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify the logic for handling Spark and Bitcoin addresses, validating parameters, and preparing data for transaction creation.

# Test: Search for similar logic in other parts of the codebase and compare for consistency.
rg --type cpp $'address handling'

Length of output: 34

---

---

Script:

#!/bin/bash
# Description: Gather information about the implementation of sAddress.decode, CBitcoinAddress, AmountFromValue, and MintAndStoreSpark.

# Find the implementation of sAddress.decode
ast-grep --lang cpp --pattern $'class Address {
  $$$
  decode($_) {
    $$$
  }
  $$$
}'

# Find the implementation of CBitcoinAddress
ast-grep --lang cpp --pattern $'class CBitcoinAddress {
  $$$
  IsValid() {
    $$$
  }
  $$$
}'

# Find the implementation of AmountFromValue
ast-grep --lang cpp --pattern $'AmountFromValue($_) {
  $$$
}'

# Find the implementation of MintAndStoreSpark
ast-grep --lang cpp --pattern $'class CWallet {
  $$$
  MintAndStoreSpark($_, $_, $_, $_) {
    $$$
  }
  $$$
}'

Length of output: 1401

---

---

Script:

#!/bin/bash
# Description: Gather information about the implementation of sAddress.decode, CBitcoinAddress, AmountFromValue, and MintAndStoreSpark with refined patterns.

# Find the implementation of sAddress.decode
ast-grep --lang cpp --pattern $'class $_ {
  $$$
  unsigned char decode($_) {
    $$$
  }
  $$$
}'

# Find the implementation of CBitcoinAddress
ast-grep --lang cpp --pattern $'class CBitcoinAddress {
  $$$
  bool IsValid() const {
    $$$
  }
  $$$
}'

# Find the implementation of AmountFromValue
ast-grep --lang cpp --pattern $'CAmount AmountFromValue(const UniValue& value) {
  $$$
}'

# Find the implementation of MintAndStoreSpark
ast-grep --lang cpp --pattern $'class CWallet {
  $$$
  std::string MintAndStoreSpark(const std::vector<CRecipient>& recipients, const std::vector<spark::MintedCoinData>& outputs, std::vector<std::pair<CWalletTx, CAmount>>& wtxAndFee, bool subtractFeeFromAmount) {
    $$$
  }
  $$$
}'

Length of output: 1621

---

---

Script:

#!/bin/bash
# Description: Gather information about the implementation of sAddress.decode, CBitcoinAddress, AmountFromValue, and MintAndStoreSpark using rg.

# Search for the implementation of sAddress.decode
rg 'decode' --type cpp

# Search for the implementation of CBitcoinAddress
rg 'CBitcoinAddress' --type cpp

# Search for the implementation of AmountFromValue
rg 'AmountFromValue' --type cpp

# Search for the implementation of MintAndStoreSpark
rg 'MintAndStoreSpark' --type cpp

Length of output: 62035

src/wallet/wallet.cpp (6)

Line range hint 1-1: LGTM! Simple and straightforward addition operation.

---

5612-5612: LGTM! Updated function signature aligns with the PR's objectives.

---

5646-5646: LGTM! Proper use of the updated CreateSparkMintTransactions function.

---

8176-8176: LGTM! Consistent update to function signature.

---

8187-8187: LGTM! Correct usage of the updated CreateSparkMintTransactions.

---

5927-5927: Verify the intention behind using empty vectors in MintAndStoreSpark.

Verification successful

Verify the context and intention behind using empty vectors in MintAndStoreSpark by examining the function definition and relevant test cases.

---

Correct the regex pattern in the rg command and re-run the ast-grep command to gather the necessary information.

---

The use of empty vectors {} in MintAndStoreSpark is intentional and validated through test cases. The tests check for expected outcomes, indicating that this usage is correct and purposeful.

• [src/wallet/test/spark_tests.cpp]

Scripts executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Check for other occurrences of MintAndStoreSpark to ensure consistency.

# Test: Search for other uses of MintAndStoreSpark. Expect: Consistent usage or clear documentation when empty vectors are passed.
rg --type cpp $'MintAndStoreSpark'

Length of output: 2187

---

---

Script:

#!/bin/bash
# Description: Retrieve the definition of MintAndStoreSpark and relevant test cases to understand the usage of empty vectors.

# Retrieve the function definition from wallet.cpp
ast-grep --lang cpp --pattern $'std::string CWallet::MintAndStoreSpark($_, $_, $_, $_, $_, $_, $_) {
  $$$
}' src/wallet/wallet.cpp

# Retrieve the relevant test cases from spark_tests.cpp
rg --type cpp --context 10 $'MintAndStoreSpark({}, {}, wtxAndFee, false, true)' src/wallet/test/spark_tests.cpp

Length of output: 388

---

---

Script:

#!/bin/bash
# Description: Retrieve the definition of MintAndStoreSpark and relevant test cases to understand the usage of empty vectors.

# Retrieve the function definition from wallet.cpp
ast-grep --lang cpp --pattern $'std::string CWallet::MintAndStoreSpark($_, $_, $_, $_, $_, $_, $_) {
  $$$
}' src/wallet/wallet.cpp

# Retrieve the relevant test cases from spark_tests.cpp with corrected regex pattern
rg --type cpp --context 10 'MintAndStoreSpark\(\{\}, \{\}, wtxAndFee, false, true\)' src/wallet/test/spark_tests.cpp

Length of output: 1581

Reviewing files that changed from the base of the PR and between 0af162e and 265c526.

• src/qt/sendcoinsdialog.cpp (4 hunks)
• src/qt/walletmodel.cpp (3 hunks)
• src/spark/sparkwallet.cpp (9 hunks)
• src/wallet/rpcwallet.cpp (3 hunks)
• src/wallet/wallet.cpp (6 hunks)
• src/wallet/wallet.h (2 hunks)

• GitHub Check: Build for Windows
• GitHub Check: Build for macOS
• GitHub Check: Build for Linux
• GitHub Check: Create Source Distribution

src/spark/sparkwallet.cpp (7)

798-799: Validate totalValue edge cases.
valueToMint + nValue could theoretically approach or exceed integer limits given extreme inputs. Consider adding overflow checks or explicit validation on high amounts.

---

833-833: Check partial usage logic.
Capping valueToSendInTx at totalValue is correct for partial usage, but ensure leftover UTXO usage is handled correctly. A quick comment clarifying the reason helps future maintainers.

---

842-842: Check the fee-splitting path.
When subtractFeeFromAmount is false, the code sets nValueToSelect to sendValue + nFeeRet, which might leave limited leftover for other operations. Validate no corner cases slip through.

Also applies to: 844-844, 846-846

---

850-851: Ensure no negative final amounts.
Subtracting nFeeRet from sendValue might slip below zero if fees exceed available amounts. Consider an explicit check to avoid unintentional negative results.

---

877-881: Validate 64-bit usage.
uint64_t remainingMintValue is assigned from sendValue (a CAmount). If sendValue can be negative, this may cause unexpected wrap. Confirm negative amounts are rejected earlier.

---

898-905: Double-check loop termination conditions.
Inside the while loop for remainingSendOutputs, watch out for partial usage of outputs or early breaks. Also confirm that the condition remainingMintValue > 0 accurately prevents infinite loops.

Also applies to: 906-912

🧰 Tools

🪛 cppcheck (2.10-2)

[error] 904-904: Uninitialized variable

(uninitvar)

---

[error] 904-904: Uninitialized struct member

(uninitStructMember)

---

1273-1274: Confirm partial transaction termination.
Subtracting sendValue from totalValue and exiting if zero is correct. However, ensure the code handles partial leftover scenarios without leaving unspent in an inconsistent state.

src/wallet/rpcwallet.cpp (1)

Line range hint 3658-3807: Review mintspark logic.

1. Validation: Verify no negative or zero amounts pass through silently; extra checks could protect from inadvertent user errors.
2. Address type checks: The code differentiates Spark addresses from transparent ones by decoding. Confirm robust handling of invalid addresses or cross-network usage.
3. Dust Handling: Ensure consistent dust threshold checks for newly created UTXOs.
4. Transaction Output Management: The final loop can produce multiple transaction outputs if certain conditions are met; consider logging or summarizing them clearly if multiple TXs result.
5. Concurrency: Since this function modifies the wallet, confirm it holds necessary locks and is safe from concurrent modifications.
   [refactor_suggestion_good_to_have, verify]

src/wallet/wallet.h (2)

Line range hint 1043-1050: LGTM! Method signature updated to support multi-send functionality.

The CreateSparkMintTransactions method signature has been updated to include const std::vector<CRecipient>& vecSend parameter, which enables handling multiple recipients in a single mint transaction.

---

Line range hint 1094-1101: LGTM! Method signature updated to support multi-send functionality.

The MintAndStoreSpark method signature has been updated to include const std::vector<CRecipient>& vecSend parameter, which enables handling multiple recipients in a single mint transaction.

src/qt/walletmodel.cpp (2)

Line range hint 1364-1396: LGTM! Enhanced address validation and processing for multi-send support.

The code now properly handles both standard and Spark addresses:

1. Standard addresses are added to vecSend with proper script generation
2. Spark addresses are added to outputs with proper address decoding
3. Input validation is comprehensive for both address types

---

1417-1418: Verify the transaction creation call.

The call to CreateSparkMintTransactions now includes both vecSend and outputs vectors to support multi-send functionality. Ensure that the transaction fee calculation and change handling work correctly with multiple recipients.

Run this script to verify the transaction creation:

✅ Verification successful

Transaction creation call verified successfully

The CreateSparkMintTransactions implementation correctly handles multiple recipients and outputs, with proper fee calculation and change management across all call sites. The extensive test coverage confirms the multi-send functionality works as intended.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if CreateSparkMintTransactions is called with correct parameters
# and verify fee calculation with multiple recipients

ast-grep --pattern $'CreateSparkMintTransactions\($$$, vecSend, outputs, $$$\)'

Length of output: 246

---

Script:

#!/bin/bash
# Search for CreateSparkMintTransactions occurrences
rg "CreateSparkMintTransactions" -A 5

# Find relevant implementation files
fd -t f ".*wallet.*\.(cpp|h)" -X rg "CreateSparkMintTransactions"

# Look for test files
fd -t f ".*test.*\.(cpp|h)" -X rg "Spark.*Mint"

Length of output: 7068

src/qt/sendcoinsdialog.cpp (4)

Line range hint 390-397: LGTM! Updated transaction preparation logic for Spark addresses.

The condition for preparing mint Spark transaction has been updated to handle cases where some recipients are Spark addresses. The code now properly checks if Spark is allowed before proceeding.

---

Line range hint 549-558: LGTM! Enhanced fee calculation for multi-send transactions.

The code now properly accumulates transaction fees and sizes for multiple transactions when sending to Spark addresses. This ensures accurate fee calculation in multi-send scenarios.

---

Line range hint 584-593: LGTM! Updated total amount calculation for multi-send transactions.

The code now correctly calculates the total amount based on the transaction type:

1. For mint Spark transactions: total = mintSparkAmount + txFee
2. For spend Spark transactions: total = amount + fee (with fee subtraction handling)

---

Line range hint 626-630: LGTM! Updated send coins logic for multi-send transactions.

The code now properly handles different transaction types and ensures correct processing of multi-send transactions with Spark addresses.

src/wallet/wallet.cpp (5)

Line range hint 5660-5684: LGTM: Parameter changes for multi-send support look good

The changes to CreateSparkMintTransactions parameters properly support the multi-send functionality by adding vecSend and outputs parameters, along with subtractFeeFromAmount flag. The implementation correctly checks for subtractFeeFromAmount in the recipients.

---

Line range hint 8235-8245: LGTM: Proper null checks and balance handling

The GetSparkBalance implementation correctly handles the sparkWallet null case and properly separates confirmed/unconfirmed balances.

---

Line range hint 8285-8397: LGTM: Proper locking and validation in DelAddressBook

The DelAddressBook implementation correctly handles locking and validation for different address types. The error handling and notifications are properly implemented.

---

Line range hint 8398-8421: LGTM: Clean implementation of validation functions

The address validation functions are well implemented with proper error handling and clear separation between standard and Spark addresses.

---

Line range hint 8422-8476: LGTM: RAP address book management properly implemented

The RAP address book management functions follow the same pattern as other address book functions with proper locking and notifications.