Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vCPU Hotplug Performance Tests #4722

Draft
wants to merge 2 commits into
base: feature/vcpu-hotplug
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Aug 6, 2024

Changes

Add non-CI performance tests for vCPU hot-plugging

Reason

To facilitate the performance analysis of vCPU hot-plugging (should it need to be analysed again)

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this
    PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet
    contribution quality standards.

  • This functionality cannot be added in rust-vmm.

@ghost ghost changed the base branch from main to feature/vcpu-hotplug August 6, 2024 12:24
@ghost ghost force-pushed the vcpu-hotplug-performance-tests branch from d7f4688 to 894391c Compare August 7, 2024 12:17
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.94%. Comparing base (a541725) to head (1cb9072).

Files Patch % Lines
src/vmm/src/lib.rs 33.33% 4 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##           feature/vcpu-hotplug    #4722      +/-   ##
========================================================
- Coverage                 81.95%   81.94%   -0.01%     
========================================================
  Files                       257      257              
  Lines                     31762    31768       +6     
========================================================
+ Hits                      26031    26033       +2     
- Misses                     5731     5735       +4     
Flag Coverage Δ
5.10-c5n.metal 82.06% <33.33%> (-0.01%) ⬇️
5.10-m5n.metal 82.05% <33.33%> (-0.01%) ⬇️
5.10-m6a.metal 81.37% <33.33%> (-0.02%) ⬇️
5.10-m6g.metal 79.21% <ø> (ø)
5.10-m6i.metal 82.04% <33.33%> (-0.01%) ⬇️
5.10-m7g.metal 79.21% <ø> (ø)
6.1-c5n.metal 82.06% <33.33%> (-0.01%) ⬇️
6.1-m5n.metal 82.05% <33.33%> (-0.01%) ⬇️
6.1-m6a.metal 81.37% <33.33%> (-0.02%) ⬇️
6.1-m6g.metal 79.21% <ø> (ø)
6.1-m6i.metal 82.05% <33.33%> (-0.01%) ⬇️
6.1-m7g.metal 79.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghost ghost force-pushed the vcpu-hotplug-performance-tests branch 5 times, most recently from bf763f9 to 4255c2e Compare August 7, 2024 14:40
@roypat roypat force-pushed the feature/vcpu-hotplug branch from a8819ed to 4faee33 Compare August 7, 2024 14:54
@ghost ghost force-pushed the vcpu-hotplug-performance-tests branch 21 times, most recently from 65ea7a1 to 539316f Compare August 14, 2024 15:33
@ghost ghost force-pushed the vcpu-hotplug-performance-tests branch 4 times, most recently from 109bd54 to 126f126 Compare August 19, 2024 09:07
@ghost ghost force-pushed the vcpu-hotplug-performance-tests branch from 126f126 to e699567 Compare August 22, 2024 13:35
Change the boot timer timestamp to be public, so that the timer can also
be used for measuring hotplugging

Signed-off-by: James Curtis <jxcurtis@amazon.co.uk>
@ghost ghost force-pushed the vcpu-hotplug-performance-tests branch 2 times, most recently from c40d67c to e83fba8 Compare August 22, 2024 14:52
@ghost ghost added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Aug 22, 2024
Create performance tests that measure the latency of hotplugging using
both a udev rule and an a userspace agent to online vCPUs.

Signed-off-by: James Curtis <jxcurtis@amazon.co.uk>
@ghost ghost force-pushed the vcpu-hotplug-performance-tests branch from e83fba8 to 1cb9072 Compare August 23, 2024 12:48
@ghost ghost marked this pull request as ready for review August 28, 2024 08:23
@ghost ghost marked this pull request as draft August 29, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant