-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vCPU Hotplug Performance Tests #4722
Draft
ghost
wants to merge
2
commits into
firecracker-microvm:feature/vcpu-hotplug
Choose a base branch
from
JamesC1305:vcpu-hotplug-performance-tests
base: feature/vcpu-hotplug
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
vCPU Hotplug Performance Tests #4722
ghost
wants to merge
2
commits into
firecracker-microvm:feature/vcpu-hotplug
from
JamesC1305:vcpu-hotplug-performance-tests
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
vcpu-hotplug-performance-tests
branch
from
August 7, 2024 12:17
d7f4688
to
894391c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/vcpu-hotplug #4722 +/- ##
========================================================
- Coverage 81.95% 81.94% -0.01%
========================================================
Files 257 257
Lines 31762 31768 +6
========================================================
+ Hits 26031 26033 +2
- Misses 5731 5735 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ghost
force-pushed
the
vcpu-hotplug-performance-tests
branch
5 times, most recently
from
August 7, 2024 14:40
bf763f9
to
4255c2e
Compare
roypat
force-pushed
the
feature/vcpu-hotplug
branch
from
August 7, 2024 14:54
a8819ed
to
4faee33
Compare
ghost
force-pushed
the
vcpu-hotplug-performance-tests
branch
21 times, most recently
from
August 14, 2024 15:33
65ea7a1
to
539316f
Compare
ghost
force-pushed
the
vcpu-hotplug-performance-tests
branch
4 times, most recently
from
August 19, 2024 09:07
109bd54
to
126f126
Compare
ghost
force-pushed
the
vcpu-hotplug-performance-tests
branch
from
August 22, 2024 13:35
126f126
to
e699567
Compare
Change the boot timer timestamp to be public, so that the timer can also be used for measuring hotplugging Signed-off-by: James Curtis <jxcurtis@amazon.co.uk>
ghost
force-pushed
the
vcpu-hotplug-performance-tests
branch
2 times, most recently
from
August 22, 2024 14:52
c40d67c
to
e83fba8
Compare
ghost
added
the
Status: Awaiting review
Indicates that a pull request is ready to be reviewed
label
Aug 22, 2024
Create performance tests that measure the latency of hotplugging using both a udev rule and an a userspace agent to online vCPUs. Signed-off-by: James Curtis <jxcurtis@amazon.co.uk>
ghost
force-pushed
the
vcpu-hotplug-performance-tests
branch
from
August 23, 2024 12:48
e83fba8
to
1cb9072
Compare
ghost
marked this pull request as ready for review
August 28, 2024 08:23
ghost
marked this pull request as draft
August 29, 2024 09:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add non-CI performance tests for vCPU hot-plugging
Reason
To facilitate the performance analysis of vCPU hot-plugging (should it need to be analysed again)
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
PR.
CHANGELOG.md
.TODO
s link to an issue.contribution quality standards.
rust-vmm
.