Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotplug Integration Tests #4704

Open
wants to merge 2 commits into
base: feature/vcpu-hotplug
Choose a base branch
from
Open

Hotplug Integration Tests #4704

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 24, 2024 •
edited by ghost
Loading

Changes

Add functional integration tests for vCPU hot-plugging

Reason

To ensure that everything works as intended

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this
    PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet
    contribution quality standards.
  • This functionality cannot be added in rust-vmm.

@roypat roypat changed the base branch from main to feature/vcpu-hotplug July 26, 2024 06:27
@kanpov
Copy link
Contributor

kanpov commented Jul 28, 2024

Will the hotplug features possibly land in 1.9?

@roypat
Copy link
Contributor

roypat commented Jul 29, 2024 •
edited
Loading

Will the hotplug features possibly land in 1.9?

Hi @kanpov, thanks for your interest in the vcpu hotplugging feature!
We currently do not have an estimate of when/if hotplugging will be released, as we are still in a prototyping/researching phase to assess whether the feature would even have acceptable performance for Firecracker's usecase. Could you describe your usecase for hotplugging a bit more over in our tracking issue? That will help us with prioritization and assessment of the feature :)

roypat
roypat previously approved these changes Aug 1, 2024
View reviewed changes
@ghost ghost force-pushed the hotplug-integration-tests branch from 3af1fc3 to aced9b1 Compare August 7, 2024 10:08
@codecov Codecov
Copy link

codecov bot commented Aug 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.95%. Comparing base (a541725) to head (f050f98).

Additional details and impacted files 
@@                  Coverage Diff                  @@
##           feature/vcpu-hotplug    #4704   +/-   ##
=====================================================
  Coverage                 81.95%   81.95%           
=====================================================
  Files                       257      257           
  Lines                     31762    31762           
=====================================================
  Hits                      26031    26031           
  Misses                     5731     5731
Flag Coverage Δ
5.10-c5n.metal 82.07% <ø> (ø)
5.10-m5n.metal 82.06% <ø> (+<0.01%) ⬆️
5.10-m6a.metal 81.38% <ø> (ø)
5.10-m6g.metal 79.21% <ø> (ø)
5.10-m6i.metal 82.06% <ø> (+<0.01%) ⬆️
5.10-m7g.metal 79.21% <ø> (ø)
6.1-c5n.metal 82.06% <ø> (-0.01%) ⬇️
6.1-m5n.metal 82.05% <ø> (ø)
6.1-m6a.metal 81.38% <ø> (ø)
6.1-m6g.metal 79.21% <ø> (ø)
6.1-m6i.metal 82.05% <ø> (ø)
6.1-m7g.metal 79.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghost ghost force-pushed the hotplug-integration-tests branch 2 times, most recently from 8da1a8f to 0ba64b9 Compare August 7, 2024 11:27
@roypat roypat force-pushed the feature/vcpu-hotplug branch from a8819ed to 4faee33 Compare August 7, 2024 14:54
@ghost ghost force-pushed the hotplug-integration-tests branch 3 times, most recently from fcc2f79 to 2ff7b52 Compare August 22, 2024 12:45
@ghost ghost marked this pull request as ready for review August 22, 2024 12:46
@JamesC1305
Add hotplug endpoint to test API representation
2b7d7be 
Extend the python test API to include the hotplug endpoint.

Signed-off-by: James Curtis <jxcurtis@amazon.co.uk>
@ghost ghost force-pushed the hotplug-integration-tests branch 5 times, most recently from bb2d108 to 08a69a8 Compare August 22, 2024 15:22
@JamesC1305
Create functional integration tests for hotplugging
f050f98 
Create some functional integration tests for hotplugging. Covering
positive and negative cases, as well as onlining of vCPUs

Signed-off-by: James Curtis <jxcurtis@amazon.co.uk>
@ghost ghost force-pushed the hotplug-integration-tests branch from 08a69a8 to f050f98 Compare August 22, 2024 15:33
@ghost ghost added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kanpov @roypat @JamesC1305