-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typeahead service should be case insensitive #530
Comments
Really? Not sure I agree... |
@chrisjstevo You mean
|
@chrisjstevo why do you think case matters? if user wants to search for, say "london" and uses a startsWith, and they get no results, because the description happens to start "London" or they get back only some of the results because the casing is not consistent in the data, doesn't feel to me like we're doing them any favours. |
The code for the filter for inmemory table found |
Need to address this in the StartWith typehaead function. Do we need to make the string filter functions also case insensitive? i.e. contains, equal, in |
Wendy will be working on this |
To summarize, following need to be reviewed in typeahead & string based filter (equal, in, contains, starts, end, not equal) functionality
Proposal We need to support both case in-sensitive & case sensitive use cases. |
If we make typeahead only case insensitive (and not the actual filtering) the problematic use cases are In these cases, the user is entering the filter pattern that will actually be sent to the server. In the case of a simple In the case (pun intended) of a |
Typeahead service should being back any values matching user pattern irrespective of case.
The text was updated successfully, but these errors were encountered: