Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create child orders in IgniteOrderLoaderMain created less than expected due to method is not threadsafe #1326

Open
keikeicheung opened this issue May 5, 2024 · 3 comments
Open

Create child orders in IgniteOrderLoaderMain created less than expected due to method is not threadsafe #1326

keikeicheung opened this issue May 5, 2024 · 3 comments
Assignees
@wendymiaoo
Labels
demo good first issue Good for newcomers server

Comments

@keikeicheung
Copy link
Contributor

in IgniteOrderLoaderMain
It loops to create parent Orders and child order (random * 100 - 250) in multiple threads
OrdersModel.createChild it creates child order with an incremental child order id (which is not threadsafe)
hence some child orders are not "new" child order but "update" existing child order
@keikeicheung keikeicheung added good first issue Good for newcomers demo labels May 5, 2024
@wendymiaoo
Copy link
Contributor

Hi @keikeicheung , Wendy would like to take a look into this if it hasn't been picked by others yet.

@wendymiaoo wendymiaoo mentioned this issue May 29, 2024
Merged
@wendymiaoo
Copy link
Contributor

Hi @junaidzm13, @keikeicheung , could you help review the code?

@wendymiaoo
Copy link
Contributor

Added @naleeha for review as well :)

@naleeha naleeha moved this to ✅ Done in Vuu board Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wendymiaoo wendymiaoo

Labels
demo good first issue Good for newcomers server
Projects
Vuu board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@keikeicheung @wendymiaoo