-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
using {virtual_mode: "vertical"} and "none" causes containing web page to fail to load #129
Comments
I'm able to see part of the problem by calling So it looks like somehow somewhere |
I'm not against applying the former if this is a common error case, but pendantically I'll note that a data model that returns rows "outside" of its data bounds isn't really correct either, regardless of the window that |
@texodus That sounds right. Yeah, I have previously noticed cases where const val = formatter(content.row[column]); So when
So i do think you're right, but from a usability perspective it would be nice if Additionally, since there do seem to be cases where |
finally had a sec to play around with this. Previously my code was iterating over a range of col indices:
and was sad when
and now everything is great! @texodus So I guess one resolution would be loudly document the wobbliness of |
@texodus Another way to look at it is that the wobbliness of All of which kind of reinforces the idea that this is a docs problem, not a code problem |
Bug Report
Steps to Reproduce:
I'm trying out the new
virtual_mode
option forsetDataListener
:https://github.com/jpmorganchase/regular-table/blob/6dbee4ffe1b3c1342ae3903a39456aa9d5131cda/src/js/index.js#L272-L279
The
both
andhorizontal
options seem to work fine, but trying to use eithervertical
ornone
causes the webpage containing the<regular-table>
to fail to load.Expected Result:
vertical
andnone
functioning as described in #125Actual Result:
Before that error pops up, the page will try to load for about 30 sec (while displaying only a white screen, with no loaded sources visible in devtools).
Environment:
regular-table@0.3.0
Additional Context:
This bug is happening in a regular table included in my
<tree-finder-panel>
elementThe text was updated successfully, but these errors were encountered: