Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes off-by-one error in end_col #948

Merged
merged 2 commits into from
Feb 26, 2020
Merged

Fixes off-by-one error in end_col #948

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b16b360
Fixed off-by-one issue in `end_col` in perspective.js, fixed lint err…
texodus Feb 24, 2020
51175f0
Fix windows webpack issue
texodus Feb 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix windows webpack issue
  • Loading branch information
@texodus
texodus committed Feb 26, 2020
commit 51175f0facd9766117c95e2cb3243b3d06d0ea59
5 changes: 4 additions & 1 deletion packages/perspective-webpack-plugin/src/js/switch-inline-loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,15 @@
*
*/

const path = require("path");

exports.default = function pitch(request) {
return request;
};

exports.pitch = function(request) {
return `module.exports = require("${request.replace("umd/perspective.inline", "esm/perspective.parallel")}");`;
const new_path = request.replace(/umd[/\\]perspective.inline/, path.join("esm", "perspective.parallel")).replace(/\\/g, "\\\\");
return `module.exports = require("${new_path}");`;
};

exports.raw = true;