Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<perspective-viewer> UI cleanup #905

Merged
merged 10 commits into from
Feb 5, 2020
Merged

<perspective-viewer> UI cleanup #905

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
77781f8
Fixes hypergrid console spamming when removed from DOM.
texodus Feb 2, 2020
b1cf3a8
Pre-size plugin on responsive column check.
texodus Feb 3, 2020
2fd8fe1
Fixes over-aggressive attribute reflection in `perspective-viewer`, a…
texodus Feb 3, 2020
b6bae10
Fixes #878
texodus Feb 3, 2020
a3dd975
Adds support for `Promise<Table>` to `PerspectiveViewerHTMLElement.lo…
texodus Feb 3, 2020
84d741a
Style improvements, move commas to end of items in a list.
texodus Feb 4, 2020
718f172
Better tab styling & other visual fixes.
texodus Feb 3, 2020
3eba691
Fix bug in `perspective-toggle-config` event dispatch order.
texodus Feb 3, 2020
b8015e9
Fixed `perspective-viewer` computed column UX overdraw
texodus Feb 4, 2020
2ed7814
Fixed tests
texodus Feb 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed perspective-viewer computed column UX overdraw
  • Loading branch information
@texodus
texodus committed Feb 4, 2020
commit b8015e9c9c7a640bf056656b7f577debe7e4a5e5
23 changes: 15 additions & 8 deletions packages/perspective-viewer/src/js/viewer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,20 +186,27 @@ class PerspectiveViewer extends ActionElement {
computed_columns = [];
}
const resolve = this._set_updating();
this._computed_column._close_computed_column();

(async () => {
if (this._table) {
const computed_schema = await this._table.computed_schema();
this._computed_column._close_computed_column();
for (let col of computed_columns) {
await this._create_computed_column({
detail: {
column_name: col.name,
input_columns: col.inputs.map(x => ({name: x})),
computation: COMPUTATIONS[col.func]
}
});
if (!computed_schema[col.name]) {
await this._create_computed_column({
detail: {
column_name: col.name,
input_columns: col.inputs.map(x => ({name: x})),
computation: COMPUTATIONS[col.func]
}
});
}
}

await this._debounce_update();
resolve();
} else {
this._computed_column._close_computed_column();
}
this.dispatchEvent(new Event("perspective-config-update"));
this.dispatchEvent(new Event("perspective-computed-column-update"));
Expand Down
1 change: 0 additions & 1 deletion packages/perspective-viewer/src/js/viewer/action_element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ export class ActionElement extends DomElement {
const cols = await this._table.columns();
// edit overwrites last column, otherwise avoid name collision
if (cols.includes(computed_column_name)) {
console.log(computed_column_name);
computed_column_name += ` ${Math.round(Math.random() * 100)}`;
}

Expand Down