Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column chooser #9

Merged
merged 13 commits into from
Jan 22, 2018
Merged

Column chooser #9

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3559d82
Clean up hypergrid plugin API.
texodus Jan 10, 2018
4cd780a
Changed column selector to "active" and "inactive" sections
texodus Jan 16, 2018
30c505c
Drag & drop for column selection.
texodus Jan 16, 2018
6f96bed
Added drag & drop indicator animation.
texodus Jan 17, 2018
11fe565
Fixed CSS jitter bug in column drag & drop.
texodus Jan 17, 2018
92979c0
Modified drag behavior to remove dragged column when in the active co…
texodus Jan 19, 2018
c6a1ca3
Cleanup.
texodus Jan 20, 2018
83f2f19
Refined plugin behavior for new column selector.
texodus Jan 21, 2018
5cd4ba8
Updated tests.
texodus Jan 21, 2018
2c73e09
Fixed performance bug which caused a dragged node to be inserted befo…
texodus Jan 21, 2018
64bf6f4
Added drag animation.
texodus Jan 21, 2018
ffa17bb
Update test regression.
texodus Jan 22, 2018
2d07b2d
Fix CSS issues for large column sets which trigger scroll.
texodus Jan 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed performance bug which caused a dragged node to be inserted befo… 
…re itself.
  • Loading branch information
@texodus
texodus committed Jan 21, 2018
commit 2c73e09003a0fe2cc17c597b882162a78ff230ba
8 changes: 5 additions & 3 deletions packages/perspective-viewer/src/js/view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,14 @@ function column_dragover(event) {
this._drop_target_hover.setAttribute('drop-target', true);
}
let index = calc_index.call(this, event);
if (this._active_columns.children[index]) {
if (!this._active_columns.children[index].hasAttribute('drop-target')) {
if (index < this._active_columns.children.length) {
if (!this._active_columns.children[Math.max(index - 1, 0)].hasAttribute('drop-target') && !this._active_columns.children[index].hasAttribute('drop-target')) {
this._active_columns.insertBefore(this._drop_target_hover, this._active_columns.children[index]);
}
} else {
this._active_columns.appendChild(this._drop_target_hover);
if (!this._active_columns.children[this._active_columns.children.length - 1].hasAttribute('drop-target')) {
this._active_columns.appendChild(this._drop_target_hover);
}
}
}

Expand Down