Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#524] Provide human-readable dates (optionally?) from Perspective to_csv() method #657

Closed
wants to merge 5 commits into from
Closed

[#524] Provide human-readable dates (optionally?) from Perspective to_csv() method #657

wants to merge 5 commits into from

Conversation

mg14777
Copy link
Contributor

@mg14777 mg14777 commented Jul 13, 2019

Fixes #524

Dates are now formatted to a human readable format based on default locale on converting to csv or json. Tests added for to_json.

@texodus Request for review

image

@finos-admin
Copy link
Member

Thank you for your pull request and welcome to our community! We require contributors to sign a Contributor License Agreement and we don't seem to have CLAs on file for these contributors to the Pull Request: (@mg14777). In order for your PR to be reviewed and merged, please follow the directions at the link above.

Project team: please do not merge this Pull Request until Foundation staff have confirmed that a CLA is in place for the new contributor(s) listed above.

If you still have any questions or just don't know what to do next, please email help@finos.org. /CC @finos-admin

@mg14777 mg14777 changed the title 524 human readable dates [#524] Provide human-readable dates (optionally?) from Perspective to_csv() method Jul 13, 2019
@finos-admin
Copy link
Member

Thank you for your pull request and welcome to our community! We require contributors to sign a Contributor License Agreement and we don't seem to have CLAs on file for these contributors to the Pull Request: (@mg14777). In order for your PR to be reviewed and merged, please follow the directions at the link above.

Project team: please do not merge this Pull Request until Foundation staff have confirmed that a CLA is in place for the new contributor(s) listed above.

If you still have any questions or just don't know what to do next, please email help@finos.org. /CC @finos-admin

@timkpaine timkpaine added bug Concrete, reproducible bugs JS labels Aug 29, 2019
@texodus texodus mentioned this pull request Aug 30, 2019
Merged
@texodus
Copy link
Member

texodus commented Aug 30, 2019 •
edited
Loading

Thanks for the PR! I've cleaned this up and rebased as #695, fixes:

  • Fix respected datetime but not date types (and this was covered by the unit test also).
  • Tests were written for toLocaleString() which does failed test due to TravisCI running in a different locale.
  • Changed implementation to use Intl.
  • Lint and C++ commits were dropped. I think you are using a different version of clang-format? Instead Readable dates #695 cherry-picks 17051fc and faa36f1 only.

Closing this PR in favor of #695.

@texodus texodus closed this Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Concrete, reproducible bugs JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide human-readable dates (optionally?) from Perspective to_csv() method
4 participants
@mg14777 @finos-admin @texodus @timkpaine