Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Multi Chart" that allows mix-and-match of different series types #586

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Added "Multi Chart" that allows mix-and-match of different series types #586

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
71b4849
Added new mix chart for mixing chart types
andy-lee-eng May 17, 2019
6ef848e
Added buttons for cycling through series types on each y-axis
andy-lee-eng May 17, 2019
c53507e
Added Area and Y-Scatter series types to the multi=chart
andy-lee-eng May 17, 2019
63aa22e
Allow changing series type when only one aggregate
andy-lee-eng May 17, 2019
a3ca216
Added legend position to preserved settings
andy-lee-eng May 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Added legend position to preserved settings 
Legend position is preserved when the chart structure changes.
  • Loading branch information
@andy-lee-eng
andy-lee-eng committed May 27, 2019
commit a3ca216d55a97545b19b2f2eb482056cd0b85dd8
3 changes: 2 additions & 1 deletion packages/perspective-viewer-d3fc/src/js/plugin/template.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ class D3FCChartElement extends HTMLElement {

// Some settings can be preserved even when the chart schema changes
const preserved = oldSettings && {
multiTypes: oldSettings.multiTypes
multiTypes: oldSettings.multiTypes,
legend: oldSettings.legend && {left: oldSettings.legend.left, top: oldSettings.legend.top}
};
return {...preserved, ...newSettings};
}
Expand Down